linux-kernel - Re: [PATCH v5 2/6] reset: imx8mp-audiomix: Replace mask with bit index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSR8q5cE/XXbZuF0@lizhi-Precision-Tower-5810>
Date: Mon, 24 Nov 2025 10:41:31 -0500
From: Frank Li <Frank.li@....com>
To: Laurentiu Mihalcea <laurentiumihalcea111@...il.com>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Fabio Estevam <festevam@...il.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Daniel Baluta <daniel.baluta@....com>,
	Shengjiu Wang <shengjiu.wang@....com>, devicetree@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Pengutronix Kernel Team <kernel@...gutronix.de>
Subject: Re: [PATCH v5 2/6] reset: imx8mp-audiomix: Replace mask with bit
 index

On Mon, Nov 24, 2025 at 01:28:32AM -0800, Laurentiu Mihalcea wrote:
>
> On 11/21/2025 7:38 AM, Frank Li wrote:
> > On Fri, Nov 14, 2025 at 05:37:34AM -0800, Laurentiu Mihalcea wrote:
> >> From: Laurentiu Mihalcea <laurentiu.mihalcea@....com>
> >>
> >> Replace the reset map mask with the bit index to make it clear that all
> >> reset lines are managed by exactly 1 bit.
> > I don't think there are benefit because I met some periphal need a magic
> > number to reset.
>
>
> Please provide more information. What SoC? Which peripherals? What block control?
>

I can't reminder exact one. I grep some code

[IMX8MP_MEDIABLK_PD_LCDIF_1] = {
                .name = "mediablk-lcdif-1",
                .clk_names = (const char *[]){ "disp1", "apb", "axi", },
                .num_clks = 3,
                .gpc_name = "lcdif1",
                .rst_mask = BIT(4) | BIT(5) | BIT(23),
                .clk_mask = BIT(4) | BIT(5) | BIT(23),
                .path_names = (const char *[]){"lcdif-rd", "lcdif-wr"},
                .num_paths = 2,
        },

mask is more extenable and easily support more hardware in future. Change
to bit number have not big benefit.

Frank