linux-kernel - Re: [PATCH v2] phy: ti: da8xx-usb: Handle devm_pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f66362b-475f-41c1-82c5-d5be7646541f@linaro.org>
Date: Mon, 24 Nov 2025 17:38:53 +0100
From: neil.armstrong@...aro.org
To: Haotian Zhang <vulab@...as.ac.cn>, vkoul@...nel.org, kishon@...nel.org
Cc: linux-phy@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] phy: ti: da8xx-usb: Handle devm_pm_runtime_enable()
 errors

On 11/24/25 11:57, Haotian Zhang wrote:
> devm_pm_runtime_enable() can fail due to memory allocation. The current
> code ignores its return value after calling pm_runtime_set_active(),
> leaving the device in an inconsistent state if runtime PM initialization
> fails.
> 
> Check the return value of devm_pm_runtime_enable() and return on
> failure. Also move the declaration of 'ret' to the function scope
> to support this check.
> 
> Fixes: ee8e41b5044f ("phy: ti: phy-da8xx-usb: Add runtime PM support")
> Suggested-by: Neil Armstrong <neil.armstrong@...aro.org>
> Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>
> ---
> Changes in v2:
>    -Just return ret and drop the dev_err() as suggested by Neil
>    Armstrong.
> ---
>   drivers/phy/ti/phy-da8xx-usb.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/phy/ti/phy-da8xx-usb.c b/drivers/phy/ti/phy-da8xx-usb.c
> index 1d81a1e6ec6b..62fa6f89c0e6 100644
> --- a/drivers/phy/ti/phy-da8xx-usb.c
> +++ b/drivers/phy/ti/phy-da8xx-usb.c
> @@ -180,6 +180,7 @@ static int da8xx_usb_phy_probe(struct platform_device *pdev)
>   	struct da8xx_usb_phy_platform_data *pdata = dev->platform_data;
>   	struct device_node	*node = dev->of_node;
>   	struct da8xx_usb_phy	*d_phy;
> +	int ret;
>   
>   	d_phy = devm_kzalloc(dev, sizeof(*d_phy), GFP_KERNEL);
>   	if (!d_phy)
> @@ -233,8 +234,6 @@ static int da8xx_usb_phy_probe(struct platform_device *pdev)
>   			return PTR_ERR(d_phy->phy_provider);
>   		}
>   	} else {
> -		int ret;
> -
>   		ret = phy_create_lookup(d_phy->usb11_phy, "usb-phy",
>   					"ohci-da8xx");
>   		if (ret)
> @@ -249,7 +248,9 @@ static int da8xx_usb_phy_probe(struct platform_device *pdev)
>   			  PHY_INIT_BITS, PHY_INIT_BITS);
>   
>   	pm_runtime_set_active(dev);
> -	devm_pm_runtime_enable(dev);
> +	ret = devm_pm_runtime_enable(dev);
> +	if (ret)
> +		return ret;
>   	/*
>   	 * Prevent runtime pm from being ON by default. Users can enable
>   	 * it using power/control in sysfs.

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>