linux-kernel - Re: [PATCH v2 1/3] staging: rtl8723bs: Rename camel case enumeration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025112434-outbid-tidbit-3192@gregkh>
Date: Mon, 24 Nov 2025 17:45:40 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Bryant Boatright <bryant.boatright@...ton.me>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Michael Straube <straube.linux@...il.com>
Subject: Re: [PATCH v2 1/3] staging: rtl8723bs: Rename camel case enumeration

On Mon, Nov 10, 2025 at 07:49:16PM +0000, Bryant Boatright wrote:
> Adhere to Linux kernel style.
> 
> Reported by checkpatch:
> 
> CHECK: Avoid CamelCase: <ParseRes>
> CHECK: Avoid CamelCase: <ParseFailed>
> CHECK: Avoid CamelCase: <ParseUnknown>
> CHECK: Avoid CamelCase: <ParseOK>

If you are changing the name, let's pick something that makes sense:

> -enum ParseRes { ParseOK = 0, ParseUnknown = 1, ParseFailed = -1 };
> +enum parse_res { PARSE_OK = 0, PARSE_UNKNOWN = 1, PARSE_FAILED = -1 };

These should be on multiple lines too, right?

Anway, "parse_res" doesn't make much sense, how about "parse_state"?
"parse_result"?  Something else?

naming is hard :)

thanks,

greg k-h