linux-kernel - Re: [PATCH] staging: gpib: Clean-up commented-out code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025112415-suitcase-console-5b2d@gregkh>
Date: Mon, 24 Nov 2025 17:54:23 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Adam Quandour <adam.quandour@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	niharchaithanya@...il.com, dan.carpenter@...aro.org,
	matchstick@...erthere.org, dpenkler@...il.com
Subject: Re: [PATCH] staging: gpib: Clean-up commented-out code

On Mon, Nov 17, 2025 at 12:20:20PM +0300, Adam Quandour wrote:
> Remove unused code.
> 
> Signed-off-by: Adam Quandour <adam.quandour@...il.com>
> ---
>  drivers/staging/gpib/cb7210/cb7210.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/staging/gpib/cb7210/cb7210.c b/drivers/staging/gpib/cb7210/cb7210.c
> index 3e2397898a9b..24c61b151071 100644
> --- a/drivers/staging/gpib/cb7210/cb7210.c
> +++ b/drivers/staging/gpib/cb7210/cb7210.c
> @@ -1290,26 +1290,14 @@ static void cb_gpib_release(struct pcmcia_device *link)
>  
>  static int cb_gpib_suspend(struct pcmcia_device *link)
>  {
> -	//struct local_info *info = link->priv;
> -	//struct struct gpib_board *dev = info->dev;
> -
>  	if (link->open)
>  		dev_warn(&link->dev, "Device still open\n");
> -	//netif_device_detach(dev);
>  
>  	return 0;
>  }
>  
>  static int cb_gpib_resume(struct pcmcia_device *link)
>  {
> -	//struct local_info *info = link->priv;
> -	//struct struct gpib_board *dev = info->dev;
> -
> -	/*if (link->open) {
> -	 *	ni_gpib_probe(dev);	/ really?
> -	 *	//netif_device_attach(dev);
> -	 *
> -	 */
>  	return cb_gpib_config(link);
>  }
>  
> -- 
> 2.51.0
> 

The code has now moved directories :(