linux-kernel - RE: [PATCH v10 5/8] crypto: Add ML-DSA crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA4PR84MB40112676E313F24DCA0D31DFABD0A@IA4PR84MB4011.NAMPRD84.PROD.OUTLOOK.COM>
Date: Mon, 24 Nov 2025 16:58:36 +0000
From: "Elliott, Robert (Servers)" <elliott@....com>
To: David Howells <dhowells@...hat.com>
CC: Herbert Xu <herbert@...dor.apana.org.au>,
        Eric Biggers
	<ebiggers@...nel.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Petr Pavlu
	<petr.pavlu@...e.com>, Daniel Gomez <da.gomez@...nel.org>,
        Sami Tolvanen
	<samitolvanen@...gle.com>,
        "Jason A . Donenfeld" <Jason@...c4.com>,
        "Ard
 Biesheuvel" <ardb@...nel.org>,
        Stephan Mueller <smueller@...onox.de>,
        "Lukas
 Wunner" <lukas@...ner.de>,
        Ignat Korchagin <ignat@...udflare.com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "keyrings@...r.kernel.org" <keyrings@...r.kernel.org>,
        "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v10 5/8] crypto: Add ML-DSA crypto_sig support

> -----Original Message-----
> From: David Howells <dhowells@...hat.com>
> Sent: Monday, November 24, 2025 3:13 AM
> Subject: Re: [PATCH v10 5/8] crypto: Add ML-DSA crypto_sig support
...
> +++ b/crypto/mldsa.c
...
> +static unsigned int crypto_mldsa_key_size(struct crypto_sig *tfm)
> +{
> +	struct crypto_mldsa_ctx *ctx = crypto_sig_ctx(tfm);
> +
> +	switch (ctx->strength) {
> +	case MLDSA44:
> +		return MLDSA44_PUBLIC_KEY_SIZE;
> +	case MLDSA65:
> +		return MLDSA65_PUBLIC_KEY_SIZE;
> +	case MLDSA87:
> +		return MLDSA87_PUBLIC_KEY_SIZE;
> +	default:
> +		WARN_ON_ONCE(1);
> +		return 0;
> +	}
> +}
...
> +static unsigned int crypto_mldsa_max_size(struct crypto_sig *tfm)
> +{
> +	struct crypto_mldsa_ctx *ctx = crypto_sig_ctx(tfm);
> +
> +	switch (ctx->strength) {
> +	case MLDSA44:
> +		return MLDSA44_SIGNATURE_SIZE;
> +	case MLDSA65:
> +		return MLDSA65_SIGNATURE_SIZE;
> +	case MLDSA87:
> +		return MLDSA87_SIGNATURE_SIZE;
> +	default:
> +		WARN_ON_ONCE(1);
> +		return 0;
> +	}

In case there's any way userspace can trigger those, I'd rather
not have any WARN stack dumps.