linux-kernel - Re: [PATCH 1/4] ARM: dts: qcom: msm8974pro-htc-m8: add status LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSSSUahMBR8Wujni@duo.ucw.cz>
Date: Mon, 24 Nov 2025 18:13:53 +0100
From: Pavel Machek <pavel@....cz>
To: Alexandre Messier <alex@...ssier.org>
Cc: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Luca Weiss <luca@...aweiss.eu>,
	linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
	~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] ARM: dts: qcom: msm8974pro-htc-m8: add status LEDs

Hi!

> >>> Do they form a single notification led, or are they supposed
> >>> to act separately?
> >>
> >> Good point, I had to check the phone user manual to confirm. Indeed, it is
> >> referred to as a one logical notification LED. It also mentions the color can
> >> be either green or orange, it does not mention using the combined color of
> >> the two LEDs.
> >>
> >> So I would say they are supposed to act separately.
> >>
> >> Hope this answers your question, and let me know if more details are needed.
> >>
> >> BTW: I will be sending a V2 to update the color name, since the user
> >> manual says the color is orange, not amber.
> > 
> > Let's describe it as a single LED then:
> > 
> > multi-led {
> >         color = <LED_COLOR_ID_MULTI>; // notice it's not RGB
> >         function = LED_FUNCTION_STATUS;
> > 
> >         #address-cells = <1>;
> >         #size-cells = <0>;
> > 
> >         led@6 {
> >                 reg = <6>;
> >                 color = <LED_COLOR_ID_GREEN>;
> >         };
> > 
> >         led@7 {
> >                 reg = <7>;
> >                 color = <LED_COLOR_ID_ORANGE>;
> >         };
> > };
> 
> Using multi-led is fine for me.
> 
> But currently, the "qcom-lpg" driver doesn't support LED_COLOR_ID_MULTI, only
> LED_COLOR_ID_RGB. Adding support for LED_COLOR_ID_MULTI is trivial, I tested it
> and it works.
> 
> Or I can also use the "leds-group-multicolor" driver, using the two individual
> LEDs. I also tested this method and it works.
> 
> > 
> > + Pavel the LED maintainer, please take a look if you think it makes sense
> 
> If Pavel agrees using multi-led makes sense, I think the first option is the
> best. I will separate the LED patch into a new series, along with the change to
> the qcom-lpg driver to support LED_COLOR_ID_MULTI.

I see nothing horribly wrong here (and am late to the party). ID_MULTI
leds are pretty uncommon for phones, but if that's what you have...

Anyway:

LED SUBSYSTEM
M:      Lee Jones <lee@...nel.org>
M:      Pavel Machek <pavel@...nel.org>
L:      linux-leds@...r.kernel.org

Best regards,
								Pavel
-- 
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, Netanyahu and Musk!

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)