linux-kernel - Re: [PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerMac media-bay nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqKYbxwAXpMbMX20Hc_QJqbXiduUAmTbY1PX_omf5tQDvA@mail.gmail.com>
Date: Mon, 24 Nov 2025 12:31:55 -0600
From: Rob Herring <robh@...nel.org>
To: Madhavan Srinivasan <maddy@...ux.ibm.com>, Michael Ellerman <mpe@...erman.id.au>, 
	Nicholas Piggin <npiggin@...il.com>, Christophe Leroy <christophe.leroy@...roup.eu>
Cc: Stan Johnson <userm57@...oo.com>, linuxppc-dev@...ts.ozlabs.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerMac
 media-bay nodes

On Wed, Oct 29, 2025 at 12:41 PM Rob Herring (Arm) <robh@...nel.org> wrote:
>
> Similar to other PowerMac mac-io devices, the media-bay node is missing the
> "#size-cells" property.
>
> Depends-on: commit 045b14ca5c36 ("of: WARN on deprecated #address-cells/#size-cells handling")
> Reported-by: Stan Johnson <userm57@...oo.com>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>  arch/powerpc/kernel/prom_init.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Ping!

>
> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
> index 827c958677f8..f26e80cbc615 100644
> --- a/arch/powerpc/kernel/prom_init.c
> +++ b/arch/powerpc/kernel/prom_init.c
> @@ -2893,7 +2893,8 @@ static void __init fixup_device_tree_pmac(void)
>         for (node = 0; prom_next_node(&node); ) {
>                 type[0] = '\0';
>                 prom_getprop(node, "device_type", type, sizeof(type));
> -               if (prom_strcmp(type, "escc") && prom_strcmp(type, "i2s"))
> +               if (prom_strcmp(type, "escc") && prom_strcmp(type, "i2s") &&
> +                   prom_strcmp(type, "media-bay"))
>                         continue;
>
>                 if (prom_getproplen(node, "#size-cells") != PROM_ERROR)
> --
> 2.51.0
>