linux-kernel - Re: [PATCH v2 04/11] coco: guest: arm64: Add support for updating interface reports from device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq5a7bvgm1fu.fsf@kernel.org>
Date: Mon, 24 Nov 2025 11:12:13 +0530
From: Aneesh Kumar K.V <aneesh.kumar@...nel.org>
To: Jonathan Cameron <jonathan.cameron@...wei.com>
Cc: linux-coco@...ts.linux.dev, kvmarm@...ts.linux.dev,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	dan.j.williams@...el.com, aik@....com, lukas@...ner.de,
	Samuel Ortiz <sameo@...osinc.com>,
	Xu Yilun <yilun.xu@...ux.intel.com>,
	Jason Gunthorpe <jgg@...pe.ca>,
	Suzuki K Poulose <Suzuki.Poulose@....com>,
	Steven Price <steven.price@....com>,
	Bjorn Helgaas <helgaas@...nel.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Marc Zyngier <maz@...nel.org>, Will Deacon <will@...nel.org>,
	Oliver Upton <oliver.upton@...ux.dev>
Subject: Re: [PATCH v2 04/11] coco: guest: arm64: Add support for updating
 interface reports from device

Jonathan Cameron <jonathan.cameron@...wei.com> writes:

> On Mon, 17 Nov 2025 19:30:00 +0530
> "Aneesh Kumar K.V (Arm)" <aneesh.kumar@...nel.org> wrote:
>
>> Support collecting interface reports using RSI calls. The fetched
>> interface report will be cached in the host.
>> 
>> Signed-off-by: Aneesh Kumar K.V (Arm) <aneesh.kumar@...nel.org>
>
>> diff --git a/drivers/virt/coco/arm-cca-guest/arm-cca.c b/drivers/virt/coco/arm-cca-guest/arm-cca.c
>> index f4c9e529c43e..7988ff6d4b2e 100644
>> --- a/drivers/virt/coco/arm-cca-guest/arm-cca.c
>> +++ b/drivers/virt/coco/arm-cca-guest/arm-cca.c
>> @@ -212,6 +212,12 @@ static struct pci_tsm *cca_tsm_lock(struct tsm_dev *tsm_dev, struct pci_dev *pde
>>  	if (ret)
>>  		return ERR_PTR(-EIO);
>>  
>> +	ret = cca_update_device_object_cache(pdev, cca_dsc);
>> +	if (ret) {
>> +		cca_device_unlock(pdev);
>> +		return ERR_PTR(-EIO);
>
> Why not return ERR_PTR(ret);
>
>> +	}
>> +
>>  	return &no_free_ptr(cca_dsc)->pci.base_tsm;
>>  }
>>  
>> diff --git a/drivers/virt/coco/arm-cca-guest/rhi-da.c b/drivers/virt/coco/arm-cca-guest/rhi-da.c
>> index 3430d8df4424..f4fb8577e1b5 100644
>> --- a/drivers/virt/coco/arm-cca-guest/rhi-da.c
>> +++ b/drivers/virt/coco/arm-cca-guest/rhi-da.c
>> @@ -156,3 +156,47 @@ int rhi_vdev_set_tdi_state(struct pci_dev *pdev, unsigned long target_state)
>>  
>>  	return ret;
>>  }
>> +
>> +static inline int rhi_vdev_get_interface_report(unsigned long vdev_id,
>> +						unsigned long *cookie)
>> +{
>> +	unsigned long ret;
>> +
>> +	struct rsi_host_call *rhi_call __free(kfree) =
>> +		kmalloc(sizeof(struct rsi_host_call), GFP_KERNEL);
>> +	if (!rhi_call)
>> +		return -ENOMEM;
>> +
>> +	rhi_call->imm = 0;
>> +	rhi_call->gprs[0] = RHI_DA_VDEV_GET_INTERFACE_REPORT;
>> +	rhi_call->gprs[1] = vdev_id;
>> +
>> +	ret = rsi_host_call(virt_to_phys(rhi_call));
>
> Given every rsi_host_call I've seen in here is passed
> output of virt_to_phys() maybe a wrapper that does that is worthwhile?
>
> rsi_host_call_va() or something like that.
>

how about static inline unsigned long rsi_host_call(struct rsi_host_call *rhi_call)


>
>> +	if (ret != RSI_SUCCESS)
>> +		return -EIO;
>> +
>> +	*cookie = rhi_call->gprs[1];
>> +	return map_rhi_da_error(rhi_call->gprs[0]);
>> +}
>
>
>> diff --git a/drivers/virt/coco/arm-cca-guest/rsi-da.h b/drivers/virt/coco/arm-cca-guest/rsi-da.h
>> index d1f4641a0fa1..fd4792a50daf 100644
>> --- a/drivers/virt/coco/arm-cca-guest/rsi-da.h
>> +++ b/drivers/virt/coco/arm-cca-guest/rsi-da.h
>> @@ -31,4 +31,6 @@ static inline int rsi_vdev_id(struct pci_dev *pdev)
>>  
>>  int cca_device_lock(struct pci_dev *pdev);
>>  int cca_device_unlock(struct pci_dev *pdev);
>> +int cca_update_device_object_cache(struct pci_dev *pdev, struct cca_guest_dsc *dsc);
>> +
>
> If the blank line makes sense, should have been in previous patch.
>
>>  #endif