linux-kernel - RE: [PATCH 2/4] irqchip: add RZ/{T2H,N2H} Interrupt Controller (ICU) driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <877bvfi7a6.ffs@tglx>
Date: Mon, 24 Nov 2025 20:01:53 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Cosmin-Gabriel Tanislav <cosmin-gabriel.tanislav.xa@...esas.com>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Geert Uytterhoeven
 <geert+renesas@...der.be>, "magnus.damm" <magnus.damm@...il.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH 2/4] irqchip: add RZ/{T2H,N2H} Interrupt Controller
 (ICU) driver

On Mon, Nov 24 2025 at 15:28, Cosmin-Gabriel Tanislav wrote:
>> From: Thomas Gleixner <tglx@...utronix.de>
>> Sent: Monday, November 24, 2025 3:49 PM
>> 
>> On Mon, Nov 24 2025 at 12:50, Cosmin-Gabriel Tanislav wrote:
>> >> From: Thomas Gleixner <tglx@...utronix.de>
>> >> Sent: Saturday, November 22, 2025 5:56 PM
>> 
>> Can you please fix your mail-client not to copy the whole header into
>> the reply?
>
> Outlook, it's unfixable. I can remove it manually each time if it's
> too much noise.

Either that or ask your colleagues how they avoid this nonsense.

>> >> > +   if (!irq_domain) {
>> >> > +           pm_runtime_put(dev);
>> >> > +           return -ENOMEM;
>> >> > +   }
>> >>
>> >> The mix of 'return $ERR' and 'return dev_err_probe()' is confusing at best.
>> >>
>> >
>> > For ENOMEM, dev_err_probe() doesn't really print anything. ENOMEM is
>> > what other drivers seem to use for a NULL irq_domain_create_hierarchy()
>> > result.
>> 
>> That's what I was missing. Now it makes sense.
>> 
> In conclusion, should I keep the bare `return -ENOMEM` in both instances?
> Just to make sure the next version is proper.

Keep the -ENOMEM.