linux-kernel - Re: [PATCH 09/18] rust: proc-macro2: enable support in kbuild

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27735776-7538-495c-b4b7-2ae8893d28d6@nvidia.com>
Date: Mon, 24 Nov 2025 11:36:42 -0800
From: John Hubbard <jhubbard@...dia.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Nathan Chancellor <nathan@...nel.org>, Nicolas Schier <nicolas@...sle.eu>,
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
 Danilo Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org,
 linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
 patches@...ts.linux.dev
Subject: Re: [PATCH 09/18] rust: proc-macro2: enable support in kbuild

On 11/12/25 3:14 AM, Miguel Ojeda wrote:
> On Mon, Nov 10, 2025 at 8:34 PM John Hubbard <jhubbard@...dia.com> wrote:
>>
>> Looks good. But for future code and commit log readers, should
>> we leave a small comment, to explain that this was vendored in,
>> and therefore excluded from "make rustfmt"?
>>
>> An alternative approach might be to create a "vendored" subdir,
>> to make it clear which parts of the Rust for Linux code are
>> special in that way.
> 
> Sure, that can help, I will add it.

A minor thing, but, it looks like maybe this was forgotten or 
overlooked in v2?

> 
> The subdir makes sense, although it makes it into a different level
> than the other crates and I don't see it done with a folder in other
> cases either. Hmm... I will think about it.
> 
> Thanks for taking a look!
> 
> Cheers,
> Miguel


thanks,
-- 
John Hubbard