linux-kernel - Re: [PATCH] ACPI: tools: pfrut: fix memory leak and resource leak in pfrut.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0i1Q7PcNLtchETbJ+1LhtMahCn75kzVCL7Dzb-bECJ39Q@mail.gmail.com>
Date: Mon, 24 Nov 2025 20:51:33 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Malaya Kumar Rout <mrout@...hat.com>
Cc: linux-kernel@...r.kernel.org, lyude@...hat.com, malayarout91@...il.com, 
	"Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, 
	Robert Moore <robert.moore@...el.com>, linux-acpi@...r.kernel.org, 
	acpica-devel@...ts.linux.dev
Subject: Re: [PATCH] ACPI: tools: pfrut: fix memory leak and resource leak in pfrut.c

On Thu, Nov 20, 2025 at 6:00 PM Malaya Kumar Rout <mrout@...hat.com> wrote:
>
> Static analysis found an issue in pfrut.c
>
> cppcheck output before this patch:
> tools/power/acpi/tools/pfrut/pfrut.c:225:3: error: Resource leak: fd_update [resourceLeak]
> tools/power/acpi/tools/pfrut/pfrut.c:269:3: error: Resource leak: fd_update [resourceLeak]
> tools/power/acpi/tools/pfrut/pfrut.c:269:3: error: Resource leak: fd_update_log [resourceLeak]
> tools/power/acpi/tools/pfrut/pfrut.c:365:4: error: Memory leak: addr_map_capsule [memleak]
> tools/power/acpi/tools/pfrut/pfrut.c:424:4: error: Memory leak: log_buf [memleak]
>
> cppcheck output after this patch:
> No resource leaks found
>
> Fix by closing file descriptors and freeing allocated memory.
>
> Signed-off-by: Malaya Kumar Rout <mrout@...hat.com>
> ---
>  tools/power/acpi/tools/pfrut/pfrut.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tools/power/acpi/tools/pfrut/pfrut.c b/tools/power/acpi/tools/pfrut/pfrut.c
> index 44a9ecbd91e8..4d9b0177c312 100644
> --- a/tools/power/acpi/tools/pfrut/pfrut.c
> +++ b/tools/power/acpi/tools/pfrut/pfrut.c
> @@ -222,6 +222,7 @@ int main(int argc, char *argv[])
>         fd_update_log = open("/dev/acpi_pfr_telemetry0", O_RDWR);
>         if (fd_update_log < 0) {
>                 printf("PFRT device not supported - Quit...\n");
> +               close(fd_update);
>                 return 1;
>         }
>
> @@ -265,7 +266,8 @@ int main(int argc, char *argv[])
>                 printf("chunk2_size:%d\n", data_info.chunk2_size);
>                 printf("rollover_cnt:%d\n", data_info.rollover_cnt);
>                 printf("reset_cnt:%d\n", data_info.reset_cnt);
> -
> +               close(fd_update);
> +               close(fd_update_log);
>                 return 0;
>         }
>
> @@ -358,6 +360,7 @@ int main(int argc, char *argv[])
>
>                 if (ret == -1) {
>                         perror("Failed to load capsule file");
> +                       munmap(addr_map_capsule, st.st_size);
>                         close(fd_capsule);
>                         close(fd_update);
>                         close(fd_update_log);
> @@ -420,7 +423,7 @@ int main(int argc, char *argv[])
>                 if (p_mmap == MAP_FAILED) {
>                         perror("mmap error.");
>                         close(fd_update_log);
> -
> +                       free(log_buf);
>                         return 1;
>                 }
>
> --

Applied as 6.19 material, thanks!