linux-kernel - Re: [PATCH 02/10] drivers: gpu: Update ARef imports from sync::aref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bf56634c-c340-4bf6-8b25-059d1dd7bae5@nvidia.com>
Date: Mon, 24 Nov 2025 16:20:26 -0500
From: Joel Fernandes <joelagnelf@...dia.com>
To: Shankari Anand <shankari.ak0208@...il.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Arve Hjønnevåg <arve@...roid.com>,
 Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>,
 Christian Brauner <brauner@...nel.org>, Carlos Llamas <cmllamas@...gle.com>,
 Suren Baghdasaryan <surenb@...gle.com>, Danilo Krummrich <dakr@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Alexandre Courbot <acourbot@...dia.com>,
 "Rafael J . Wysocki" <rafael@...nel.org>, Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Igor Korotin <igor.korotin.linux@...il.com>,
 Michal Wilczynski <m.wilczynski@...sung.com>
Cc: Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>,
 Trevor Gross <tmgross@...ch.edu>,
 Daniel Almeida <daniel.almeida@...labora.com>,
 Abdiel Janulgue <abdiel.janulgue@...il.com>,
 Robin Murphy <robin.murphy@....com>, linux-kernel@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
 rust-for-linux@...r.kernel.org, linux-pwm@...r.kernel.org
Subject: Re: [PATCH 02/10] drivers: gpu: Update ARef imports from sync::aref

On 11/23/2025 4:24 AM, Shankari Anand wrote:
> Update call sites to import `ARef` from `sync::aref`
> instead of `types`.
> 
> This aligns with the ongoing effort to move `ARef` and
> `AlwaysRefCounted` to sync.
> 
> Suggested-by: Benno Lossin <lossin@...nel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1173
> Signed-off-by: Shankari Anand <shankari.ak0208@...il.com>

Reviewed-by: Joel Fernandes <joelagnelf@...dia.com>

thanks,

 - Joel

> ---
>  drivers/gpu/drm/tyr/driver.rs          | 2 +-
>  drivers/gpu/nova-core/gsp/sequencer.rs | 2 +-
>  drivers/gpu/nova-core/vbios.rs         | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tyr/driver.rs b/drivers/gpu/drm/tyr/driver.rs
> index 0389c558c036..264c2362237a 100644
> --- a/drivers/gpu/drm/tyr/driver.rs
> +++ b/drivers/gpu/drm/tyr/driver.rs
> @@ -16,10 +16,10 @@
>  use kernel::regulator;
>  use kernel::regulator::Regulator;
>  use kernel::sizes::SZ_2M;
> +use kernel::sync::aref::ARef;
>  use kernel::sync::Arc;
>  use kernel::sync::Mutex;
>  use kernel::time;
> -use kernel::types::ARef;
>  
>  use crate::file::File;
>  use crate::gem::TyrObject;
> diff --git a/drivers/gpu/nova-core/gsp/sequencer.rs b/drivers/gpu/nova-core/gsp/sequencer.rs
> index 2d0369c49092..9c689f0b21ab 100644
> --- a/drivers/gpu/nova-core/gsp/sequencer.rs
> +++ b/drivers/gpu/nova-core/gsp/sequencer.rs
> @@ -14,12 +14,12 @@
>      device,
>      io::poll::read_poll_timeout,
>      prelude::*,
> +    sync::aref::ARef, //
>      time::{
>          delay::fsleep,
>          Delta, //
>      },
>      transmute::FromBytes,
> -    types::ARef, //
>  };
>  
>  use crate::{
> diff --git a/drivers/gpu/nova-core/vbios.rs b/drivers/gpu/nova-core/vbios.rs
> index abf423560ff4..7c26e4a2d61c 100644
> --- a/drivers/gpu/nova-core/vbios.rs
> +++ b/drivers/gpu/nova-core/vbios.rs
> @@ -11,8 +11,8 @@
>          Alignable,
>          Alignment, //
>      },
> +    sync::aref::ARef,
>      transmute::FromBytes,
> -    types::ARef,
>  };
>  
>  use crate::{