linux-kernel - Re: [PATCH V2 4/5] f2fs: ignore discard return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251124063011.GA16808@lst.de>
Date: Mon, 24 Nov 2025 07:30:11 +0100
From: Christoph Hellwig <hch@....de>
To: Chaitanya Kulkarni <ckulkarnilinux@...il.com>
Cc: axboe@...nel.dk, agk@...hat.com, snitzer@...nel.org,
	mpatocka@...hat.com, song@...nel.org, yukuai@...as.com, hch@....de,
	sagi@...mberg.me, kch@...dia.com, jaegeuk@...nel.org,
	chao@...nel.org, cem@...nel.org, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, dm-devel@...ts.linux.dev,
	linux-raid@...r.kernel.org, linux-nvme@...ts.infradead.org,
	linux-f2fs-devel@...ts.sourceforge.net, linux-xfs@...r.kernel.org,
	bpf@...r.kernel.org
Subject: Re: [PATCH V2 4/5] f2fs: ignore discard return value

On Sun, Nov 23, 2025 at 06:57:36PM -0800, Chaitanya Kulkarni wrote:
> +		__blkdev_issue_discard(bdev,
> +				SECTOR_FROM_BLOCK(start),
> +				SECTOR_FROM_BLOCK(len),
> +				GFP_NOFS, &bio);

This can be shortened a bit as well:

		__blkdev_issue_discard(bdev, SECTOR_FROM_BLOCK(start),
				SECTOR_FROM_BLOCK(len), GFP_NOFS, &bio);

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>