linux-kernel - Re: [PATCH v2 2/2] hfs: Update sanity check of the root record

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aSTiiwtxgmO9la-p@Bertha>
Date: Mon, 24 Nov 2025 22:56:11 +0000
From: George Anthony Vernon <contact@...rnon.com>
To: Viacheslav Dubeyko <Slava.Dubeyko@....com>
Cc: "frank.li@...o.com" <frank.li@...o.com>,
	"linux-kernel-mentees@...ts.linux.dev" <linux-kernel-mentees@...ts.linux.dev>,
	"slava@...eyko.com" <slava@...eyko.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"syzbot+97e301b4b82ae803d21b@...kaller.appspotmail.com" <syzbot+97e301b4b82ae803d21b@...kaller.appspotmail.com>,
	"glaubitz@...sik.fu-berlin.de" <glaubitz@...sik.fu-berlin.de>,
	"skhan@...uxfoundation.org" <skhan@...uxfoundation.org>,
	"penguin-kernel@...ove.sakura.ne.jp" <penguin-kernel@...ove.sakura.ne.jp>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] hfs: Update sanity check of the root record

On Tue, Nov 11, 2025 at 12:34:40AM +0000, Viacheslav Dubeyko wrote:
> On Tue, 2025-11-11 at 00:23 +0000, George Anthony Vernon wrote:
> > Maybe is_valid_cnid() should be is_valid_catalog_cnid(), since that is
> > what it is actually testing for at the interface with the VFS. Would you
> > agree?
> > 
> 
> CNID is abbreviation of Catalog Node ID. So, is_valid_catalog_cnid() will sound
> like Catalog Catalog Node ID. :)
> 
> Thanks,
> Slava.
> 
Indeed, I think my thinking got muddled up late at night :)

Thanks,

George