linux-kernel - Re: [PATCH v18 1/3] dt-bindings: leds: add TI/National Semiconductor LP5812 LED Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251124-classy-lynx-of-perception-c1ef60@kuoka>
Date: Mon, 24 Nov 2025 08:55:30 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nam Tran <trannamatk@...il.com>
Cc: lee@...nel.org, pavel@...nel.org, gregkh@...uxfoundation.org, 
	rdunlap@...radead.org, christophe.jaillet@...adoo.fr, krzk+dt@...nel.org, 
	robh@...nel.org, conor+dt@...nel.org, corbet@....net, linux-leds@...r.kernel.org, 
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v18 1/3] dt-bindings: leds: add TI/National Semiconductor
 LP5812 LED Driver

On Mon, Nov 24, 2025 at 08:30:38AM +0100, Krzysztof Kozlowski wrote:
> On Mon, Nov 24, 2025 at 02:10:40AM +0700, Nam Tran wrote:
> > The LP5812 is a 4x3 RGB LED driver with an autonomous animation
> > engine and time-cross-multiplexing (TCM) support for up to 12 LEDs
> > or 4 RGB LEDs. It supports both analog (256 levels) and PWM (8-bit)
> > dimming, including exponential PWM for smooth brightness control.
> > 
> > Signed-off-by: Nam Tran <trannamatk@...il.com>
> 
> You received review from me - where did you explain reasons of dropping
> it?
> 
> You then received SECOND review from Rob and where did you explain
> reasons of ignoring/dropping it?
> 
> You will not get third review, please start respecting our work. Read
> carefully submitting patches document.

I gave it second read and found it, although I admit it is not obvious.

I really do not expect changes to the binding at v15, then again at v17.

Best regards,
Krzysztof