linux-kernel - Re: [PATCH V2 4/5] f2fs: ignore discard return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b28f4f1a-8224-4205-a3e4-4894b6cbfa89@wdc.com>
Date: Mon, 24 Nov 2025 07:56:05 +0000
From: Johannes Thumshirn <Johannes.Thumshirn@....com>
To: Chaitanya Kulkarni <ckulkarnilinux@...il.com>, "axboe@...nel.dk"
	<axboe@...nel.dk>, "agk@...hat.com" <agk@...hat.com>, "snitzer@...nel.org"
	<snitzer@...nel.org>, "mpatocka@...hat.com" <mpatocka@...hat.com>,
	"song@...nel.org" <song@...nel.org>, "yukuai@...as.com" <yukuai@...as.com>,
	hch <hch@....de>, "sagi@...mberg.me" <sagi@...mberg.me>, "kch@...dia.com"
	<kch@...dia.com>, "jaegeuk@...nel.org" <jaegeuk@...nel.org>,
	"chao@...nel.org" <chao@...nel.org>, "cem@...nel.org" <cem@...nel.org>
CC: "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dm-devel@...ts.linux.dev" <dm-devel@...ts.linux.dev>,
	"linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>,
	"linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
	"linux-f2fs-devel@...ts.sourceforge.net"
	<linux-f2fs-devel@...ts.sourceforge.net>, "linux-xfs@...r.kernel.org"
	<linux-xfs@...r.kernel.org>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>
Subject: Re: [PATCH V2 4/5] f2fs: ignore discard return value

On 11/24/25 3:58 AM, Chaitanya Kulkarni wrote:
> __blkdev_issue_discard() always returns 0, making the error assignment
> in __submit_discard_cmd() dead code.
>
> Initialize err to 0 and remove the error assignment from the
> __blkdev_issue_discard() call tp err. Move fault injection code into

s/tp/to/


> already present if branch where err is set to -EIO.
>
> This preserves the fault injection behavior while removing dead error
> handling.

Otherwise

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>