linux-kernel - Re: [PATCH 3/3] dmaengine: qcom: bam_dma: convert tasklet to a workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=McGzOEOKqkdtArALWTm3WjKNtgcw1VZzaz_7ZPgFqh=vQ@mail.gmail.com>
Date: Mon, 24 Nov 2025 08:58:24 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Vinod Koul <vkoul@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, dmaengine@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 3/3] dmaengine: qcom: bam_dma: convert tasklet to a workqueue

On Sat, Nov 22, 2025 at 10:10 AM Vinod Koul <vkoul@...nel.org> wrote:
>
> On 06-11-25, 16:44, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> > There is nothing in the interrupt handling that requires us to run in
> > atomic context so convert the tasklet to a workqueue.
>
> The reason dmaengine drivers use tasklets is higher priority to handle
> dma interrupts... This is by design for this subsystem.
>
> There was an attempt in past to do conversion away from tasklets [1]:
> We need something similar apprach here. I can queue up first two though
>
> 1: https://lore.kernel.org/all/20240327160314.9982-1-apais@linux.microsoft.com/
> --
> ~Vinod

Ah, I wasn't aware of this. I tested some simple use cases with QCE
and it worked so I assumed it's fine. Yes, please queue the first two
ones and I'll revisit this later.

Bart