linux-kernel - Re: [PATCH] clk: mediatek: Fix error handling in runtime PM setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <402f3df4-15e7-4903-ab27-fe80be609073@collabora.com>
Date: Mon, 24 Nov 2025 09:47:00 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Haotian Zhang <vulab@...as.ac.cn>, mturquette@...libre.com,
 sboyd@...nel.org, matthias.bgg@...il.com
Cc: nfraprado@...labora.com, laura.nao@...labora.com, wenst@...omium.org,
 linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] clk: mediatek: Fix error handling in runtime PM setup

Il 23/11/25 16:43, Haotian Zhang ha scritto:
> devm_pm_runtime_enable() can fail due to memory allocation. The current
> code ignores its return value, and when pm_runtime_resume_and_get() fails,
> it returns directly without unmapping the shared_io region.
> 
> Add error handling for devm_pm_runtime_enable(). Reorder cleanup labels
> to properly unmap shared_io on pm_runtime_resume_and_get() failure.
> 
> Fixes: 2f7b1d8b5505 ("clk: mediatek: Do a runtime PM get on controllers during probe")
> Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>