linux-kernel - Re: [PATCH v3 09/21] loongarch/paravirt: Use common code for paravirt_steal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e43e9885-68f1-8558-08cd-9d0ef48861f7@loongson.cn>
Date: Mon, 24 Nov 2025 17:52:09 +0800
From: Bibo Mao <maobibo@...ngson.cn>
To: Juergen Gross <jgross@...e.com>, linux-kernel@...r.kernel.org,
 loongarch@...ts.linux.dev, virtualization@...ts.linux.dev, x86@...nel.org
Cc: Huacai Chen <chenhuacai@...nel.org>, WANG Xuerui <kernel@...0n.name>,
 Ajay Kaher <ajay.kaher@...adcom.com>,
 Alexey Makhalov <alexey.makhalov@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>,
 "Peter Zijlstra (Intel)" <peterz@...radead.org>
Subject: Re: [PATCH v3 09/21] loongarch/paravirt: Use common code for
 paravirt_steal_clock()

Reviewed-by: Bibo Mao <maobibo@...ngson.cn>

On 2025/10/6 下午3:45, Juergen Gross wrote:
> Remove the arch specific variant of paravirt_steal_clock() and use
> the common one instead.
> 
> Signed-off-by: Juergen Gross <jgross@...e.com>
> Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> ---
>   arch/loongarch/Kconfig                |  1 +
>   arch/loongarch/include/asm/paravirt.h | 10 ----------
>   arch/loongarch/kernel/paravirt.c      |  7 -------
>   3 files changed, 1 insertion(+), 17 deletions(-)
> 
> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> index ea683bcea14c..7a9d1d0edc92 100644
> --- a/arch/loongarch/Kconfig
> +++ b/arch/loongarch/Kconfig
> @@ -671,6 +671,7 @@ source "kernel/livepatch/Kconfig"
>   config PARAVIRT
>   	bool "Enable paravirtualization code"
>   	depends on AS_HAS_LVZ_EXTENSION
> +	select HAVE_PV_STEAL_CLOCK_GEN
>   	help
>   	  This changes the kernel so it can modify itself when it is run
>   	  under a hypervisor, potentially improving performance significantly
> diff --git a/arch/loongarch/include/asm/paravirt.h b/arch/loongarch/include/asm/paravirt.h
> index d219ea0d98ac..0111f0ad5f73 100644
> --- a/arch/loongarch/include/asm/paravirt.h
> +++ b/arch/loongarch/include/asm/paravirt.h
> @@ -4,16 +4,6 @@
>   
>   #ifdef CONFIG_PARAVIRT
>   
> -#include <linux/static_call_types.h>
> -
> -u64 dummy_steal_clock(int cpu);
> -DECLARE_STATIC_CALL(pv_steal_clock, dummy_steal_clock);
> -
> -static inline u64 paravirt_steal_clock(int cpu)
> -{
> -	return static_call(pv_steal_clock)(cpu);
> -}
> -
>   int __init pv_ipi_init(void);
>   int __init pv_time_init(void);
>   int __init pv_spinlock_init(void);
> diff --git a/arch/loongarch/kernel/paravirt.c b/arch/loongarch/kernel/paravirt.c
> index 8caaa94fed1a..c5e526098c0b 100644
> --- a/arch/loongarch/kernel/paravirt.c
> +++ b/arch/loongarch/kernel/paravirt.c
> @@ -13,13 +13,6 @@ static int has_steal_clock;
>   static DEFINE_PER_CPU(struct kvm_steal_time, steal_time) __aligned(64);
>   DEFINE_STATIC_KEY_FALSE(virt_spin_lock_key);
>   
> -static u64 native_steal_clock(int cpu)
> -{
> -	return 0;
> -}
> -
> -DEFINE_STATIC_CALL(pv_steal_clock, native_steal_clock);
> -
>   static bool steal_acc = true;
>   
>   static int __init parse_no_stealacc(char *arg)
>