linux-kernel - Re: [v2, net-next 09/12] bng_en: Add ethtool link settings and capabilities support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANXQDtYvomG0r2v=6ppK8no867A_Njar3UX8URNtRY6OgoL_xA@mail.gmail.com>
Date: Mon, 24 Nov 2025 16:35:50 +0530
From: Bhargava Chenna Marreddy <bhargava.marreddy@...adcom.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	michael.chan@...adcom.com, pavan.chebbi@...adcom.com, 
	vsrama-krishna.nemani@...adcom.com, vikas.gupta@...adcom.com, 
	Rajashekar Hudumula <rajashekar.hudumula@...adcom.com>
Subject: Re: [v2, net-next 09/12] bng_en: Add ethtool link settings and
 capabilities support

On Thu, Nov 20, 2025 at 1:14 AM Andrew Lunn <andrew@...n.ch> wrote:
>
> > > > +     if (link_info->support_auto_speeds || link_info->support_auto_speeds2 ||
> > > > +         link_info->support_pam4_auto_speeds)
> > > > +             linkmode_set_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,
> > > > +                              lk_ksettings->link_modes.supported);
> > >
> > > autoneg is more than speed. In fact, 1000BaseX only works are 1G, no
> > > link speed negotiation, but you can negotiate pause. Do any of the
> > > link modes you support work like this?
> >
> > All the speeds we support can be auto-negotiated.
>
> If all the speeds you support can do autoneg, why do you need the if ()

We also have devices which support only fixed speeds, hence this check
is required.

When autoneg is enabled, even if the device supports a single speed like 1G,
it has to go through the process of auto-negotiation.

Thanks,
Bhargava Marreddy

>
>         Andrew

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5496 bytes)