linux-kernel - Re: [PATCH 04/10] can: grcan: Add clock handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d5828e7f-6d35-4031-82fd-b055ec1eafe5@kernel.org>
Date: Mon, 24 Nov 2025 12:10:37 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Arun Muthusamy <arun.muthusamy@...sler.com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 mkl@...gutronix.de, mailhol@...nel.org, Cc <devicetree@...r.kernel.org>,
 linux-kernel@...r.kernel.org, linux-can@...r.kernel.org,
 Daniel Hellstrom <daniel@...sler.com>
Subject: Re: [PATCH 04/10] can: grcan: Add clock handling

On 24/11/2025 10:46, Arun Muthusamy wrote:
> Hi Krzysztof,
> 
> Thank you for your thorough review. I wanted to get your guidance 
> regarding the clock property in the DT binding.
> 
> In the binding, I included the clocks property with maxItems: 1 to 
> indicate that a clock should be described. The driver calls:

Ah, you added clocks, I completely missed it.

> 
> clk = devm_clk_get(dev, NULL);
> 
> Since we pass NULL, the driver always requests the first (and only) 
> clock from the clocks property

Yes this is correct.

.
> 
> I want to ensure the binding is fully compliant with the Linux DT ABI. 

It is fine, please ignore my comment. It was a mistake.


Best regards,
Krzysztof