linux-kernel - Re: [PATCH] pinctrl: cirrus: cs42l43: Handle devm_pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSRH1FydR9VXB/Fb@opensource.cirrus.com>
Date: Mon, 24 Nov 2025 11:56:04 +0000
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Haotian Zhang <vulab@...as.ac.cn>
Cc: rf@...nsource.cirrus.com, david.rhodes@...rus.com,
        linus.walleij@...aro.org, linux-sound@...r.kernel.org,
        patches@...nsource.cirrus.com, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: cirrus: cs42l43: Handle
 devm_pm_runtime_enable() errors

On Mon, Nov 24, 2025 at 09:49:33AM +0800, Haotian Zhang wrote:
> devm_pm_runtime_enable() can fail due to memory allocation. The current
> code ignores its return value, potentially causing pm_runtime_idle() to
> operate on uninitialized runtime PM state.
> 
> Check the return value of devm_pm_runtime_enable() and return on failure.
> 
> Fixes: d5282a539297 ("pinctrl: cs42l43: Add support for the cs42l43")
> Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>
> ---

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles