linux-kernel - Re: [PATCH] platform/x86: asus-armoury: fix only DC tunables being available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <073f7f84-cd31-2e34-e282-05ae95375b04@linux.intel.com>
Date: Mon, 24 Nov 2025 15:28:37 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Denis Benato <benato.denis96@...il.com>
cc: Denis Benato <denis.benato@...ux.dev>, LKML <linux-kernel@...r.kernel.org>, 
    platform-driver-x86@...r.kernel.org, Hans de Goede <hansg@...nel.org>, 
    "Limonciello, Mario" <mario.limonciello@....com>, 
    "Luke D . Jones" <luke@...nes.dev>, Alok Tiwari <alok.a.tiwari@...cle.com>, 
    Derek John Clark <derekjohn.clark@...il.com>, 
    Mateusz Schyboll <dragonn@...pl>, porfet828@...il.com
Subject: Re: [PATCH] platform/x86: asus-armoury: fix only DC tunables being
 available

On Sun, 23 Nov 2025, Denis Benato wrote:
> On 11/23/25 16:05, Denis Benato wrote:
> > Module asus-armoury must use  AC tunables to check availability
> No idea why I missed the double space here.
> 
> Do I resend a corrected version? Should checkpatch.pl also check for this?

Thanks for the heads up.

I can take care of it while applying (and if I happen to forget the sky 
is not going to fall :-)).

-- 
 i.


> > of power-related firmware attributes: fix missing attributes
> > by using AC attributes instead of DC.
> >
> > Signed-off-by: Denis Benato <denis.benato@...ux.dev>
> > ---
> >  drivers/platform/x86/asus-armoury.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
> > index 5106e8a41e25..9c1a9ad42bc4 100644
> > --- a/drivers/platform/x86/asus-armoury.c
> > +++ b/drivers/platform/x86/asus-armoury.c
> > @@ -869,7 +869,8 @@ static bool has_valid_limit(const char *name, const struct power_limits *limits)
> >  
> >  static int asus_fw_attr_add(void)
> >  {
> > -	const struct rog_tunables *const ac_rog_tunables = asus_armoury.rog_tunables[ASUS_ROG_TUNABLE_DC];
> > +	const struct rog_tunables *const ac_rog_tunables =
> > +		asus_armoury.rog_tunables[ASUS_ROG_TUNABLE_AC];
> >  	const struct power_limits *limits;
> >  	bool should_create;
> >  	const char *name;
>