Message-ID: <f8ebe524-1f0a-4f54-96ce-aa36f8659adc@tuxedocomputers.com>
Date: Mon, 24 Nov 2025 15:09:00 +0100
From: Georg Gottleuber <g.gottleuber@...edocomputers.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
 Stephan Gerhold <stephan.gerhold@...aro.org>
Cc: Georg Gottleuber <ggo@...edocomputers.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Ettore Chimenti <ettore.chimenti@...aro.org>,
 Srinivas Kandagatla <srini@...nel.org>, stefan.schmidt@...aro.org,
 wse@...edocomputers.com, cs@...edo.de
Subject: Re: [PATCH v3 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100)

Hello Krzysztof.

Am 22.11.25 um 12:15 schrieb Krzysztof Kozlowski:
> On 22/11/2025 12:00, Stephan Gerhold wrote:
>> On Sat, Nov 22, 2025 at 11:16:25AM +0100, Krzysztof Kozlowski wrote:
>>> On 21/11/2025 15:26, Georg Gottleuber wrote:
>>>> [...]
>>>> Initial support for TUXEDO Elite 14 Gen1 laptop. It is based on Qualcomm
>>>> Snapdragon X Elite SoC (X1E78100).
>>>>
>>> [...]
>>>
>>>> Because the SoC is now outdated and some functions still do not work as
>>>> well as customers would expect from the TUXEDO brand, TUXEDO Elite 14 Gen1
>>>> will not be offered for sale. We would still like to submit our device
>>>> tree to the mainline kernel and thus contribute to Linux support for a
>>>> compatible device sold by Medion (SPRCHRGD 14 S1 Elite). At least in
>>>> Germany, this device was sold in many large stores. (An official press
>>>> statement will follow on our website.)
>>>
>>> For me this is unmergeable, because we do not take stuff which no one
>>> uses (no one can even use), and I am sad I put effort in reviewing AFTER
>>> this was known to be cancelled.

In fact, there are a couple of these TUXEDO devices, some of these are
already being used by people outside the company (by Linaro). There are
also considerations to give the engineering samples to
Linux/ARM-(kernel) enthusiasts.

>> I don't think we have any requirement to have a large user base in order
>> to merge changes. There is already support for plenty of cancelled
>> products with only a few (if any) remaining users in mainline, e.g.
>>
>>  - Snapdragon X Elite Dev Kit (x1e001de-devkit), shipped only to a
>>    handful of users before cancelled
>>  - All ChromeOS SC7280 devices (including DTB variants for several
>>    revisions of pre-production samples), never shipped to anyone
>>
> 
> I discuss here the timing primarily and I don't know the timing about them.
> 
>> There are also plenty of internal reference devices that only a handful
>> of people have access to (MTP, HDK, CRD etc). What makes these any
> 
> They are still "maintained" and "offered", even if only for handful
> (like 3000 EACH variant) people. That's the amount of board of each
> variant, e.g. MTP8750, and all of them run some sort of Linux, even if
> downstream. So sorry, but 3000 (or whatever number it is) is not handful.
> 
>> different? Ettore has been actively testing and contributing to the port
>> for the TUXEDO laptop, so if he wants to continue that, I don't think
>> anything speaks against merging this device tree.
> 
> I won't be maintaining it, so not my effort in that, but since you speak
> about that - maintenance is an effort, thus I decide not to spend it on
> cancelled products.
>> In any case, I don't think the time reviewing these changes is wasted:
> 
> I am happy that you do not find my time wasted, but I disagree on that
> because knowing this is cancelled, I would probably not care and review
> products which are not cancelled at this time.

Do you maintain your position despite the above circumstances?

>> As Georg wrote, there is also the Medion SPRCHRGD 14 S1 Elite laptop
>> that uses basically the same hardware design. I'm sure there are (or
>> eventually will be) users of that device who would appreciate having a
>> fully-functional device tree ready to use. There is an open issue in one
>> of the Ubuntu repositories for example [1] to add automatic DTB
>> selection for it.
>>
>> In other words, even if we decide against adding support for the
>> "x1e80100-tuxedo-elite-14-gen1", the same changes renamed to
>> "x1e80100-medion-sprchrgd-14-s1" would still be valid and valuable.
> 
> That's why you send such patches with RFC title and FIRST (literally
> first) explanation in cover letter WHY, so people can decide.
> 
>> I wouldn't expect any other changes to be needed, although obviously
>> someone with access to the device should confirm that before submitting.
> 
> You still cannot apply my review to that other board, so still wasted
> time because I would need to review again.

I understand your frustration, but I'm still learning how to contribute
to the Linux kernel. However, we may be able to find a constructive
solution. Here at TUXEDO, we have the necessary Medion device and have
already adapted the device tree.

Would you review a patch set for Medion SPRCHRGD 14 S1 Elite?

(This device is still on sale and can be found in many large electronics
stores, at least in Germany.)

Best regards,
Georg

> 
> Best regards,
> Krzysztof

Powered by blists - more mailing lists