linux-kernel - Re: [PATCH next] ASoC: SDCA: Fix NULL vs IS_ERR() bug in sdca_dev_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSW3MsGig4/COjyG@opensource.cirrus.com>
Date: Tue, 25 Nov 2025 14:03:30 +0000
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>,
        Maciej Strozek <mstrozek@...nsource.cirrus.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Vinod Koul <vkoul@...nel.org>, linux-sound@...r.kernel.org,
        patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] ASoC: SDCA: Fix NULL vs IS_ERR() bug in
 sdca_dev_register_functions()

On Tue, Nov 25, 2025 at 04:55:28PM +0300, Dan Carpenter wrote:
> The sdca_dev_register() function never returns NULL, it returns error
> pointers on error.  Fix the error checking to match.
> 
> Fixes: 4496d1c65bad ("ASoC: SDCA: add function devices")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles