linux-kernel - Re: [PATCH net-next 07/12] ipvlan: Don't allow children to use IPs of main

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12d4a794-24f4-4201-8671-38851edb7942@redhat.com>
Date: Tue, 25 Nov 2025 15:26:22 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Dmitry Skorodumov <skorodumov.dmitry@...wei.com>, netdev@...r.kernel.org,
 Kuniyuki Iwashima <kuniyu@...gle.com>, Xiao Liang <shaw.leon@...il.com>,
 Jakub Kicinski <kuba@...nel.org>, Julian Vetter <julian@...er-limits.org>,
 Ido Schimmel <idosch@...dia.com>, Guillaume Nault <gnault@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>, Stanislav Fomichev <sdf@...ichev.me>,
 Etienne Champetier <champetier.etienne@...il.com>,
 linux-kernel@...r.kernel.org
Cc: andrey.bokhanko@...wei.com, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next 07/12] ipvlan: Don't allow children to use IPs of
 main

On 11/20/25 6:49 PM, Dmitry Skorodumov wrote:
> Remember all ip-addresses on main iface and check
> in ipvlan_addr_busy() that addr is not used on main.

Why?

Why using in_dev_for_each_ifa_rcu()/in6_dev->addr_list is not good enough?

Note that IP addtion on the main interface can race with
ipvlan_addr_busy() even with the code you are proposing.

/P