lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <87cy56uoz4.fsf@bootlin.com>
Date: Tue, 25 Nov 2025 16:11:11 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Les Boys <lesboyspp43@...look.com>
Cc: "linux-wpan@...r.kernel.org" <linux-wpan@...r.kernel.org>,
  "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
  "alex.aring@...il.com" <alex.aring@...il.com>,
  "stefan@...enfreihafen.org" <stefan@...enfreihafen.org>
Subject: Re: [PATCH v1 2/2] net/ieee802154: use channel mask macros replace
 the hard-coded magic number

Hello,

On 25/11/2025 at 09:41:30 GMT, Les Boys <lesboyspp43@...look.com> wrote:

> This commit replaced all the hard-coded magic numbers to macros defined in
> previous commit.

Can you please slightly rephrase into "Replace all the..."

Maybe the title can be shortened a little bit as well.

While I'm fine with this addition (I haven't checked all values), we
would need a proper name and Signed-off-by tag.

Thanks,
Miquèl

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ