linux-kernel - Re: [PATCH v2 08/12] x86/bug: Add BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHk-=wj_X=y3A0pnTn3C=eM-GBNvepjtdYawuOeU-0XdHYs4Sg@mail.gmail.com>
Date: Tue, 25 Nov 2025 08:27:50 -0800
From: Linus Torvalds <torvalds@...uxfoundation.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: x86@...nel.org, ardb@...nel.org, linux-kernel@...r.kernel.org, 
	kees@...nel.org, acarmina@...hat.com, jpoimboe@...nel.org, 
	mark.rutland@....com, maciej.wieczor-retman@...el.com
Subject: Re: [PATCH v2 08/12] x86/bug: Add BUG_FORMAT basics

On Tue, 25 Nov 2025 at 07:17, Peter Zijlstra <peterz@...radead.org> wrote:
>
> Ard came up with this glorious hack :-)

"glorious".

Hmm. I _really_ don't love how it now uses that odd label across
macros, it's not screaming "obvious" to me.

How bad would it be to just not use a NULL pointer at all, and instead
make the "no format" be "empty format"?

(Slightly related thing: could we perhaps just make x86-32 also use
the relative format, and get rid of some of the horrid #ifdef's in the
x86 <asm/bug.h> implementation? Because that "__BUG_REL" thing is not
a thing of beauty either).

             Linus