linux-kernel - Re: [rtla 05/13] rtla: Simplify argument parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <301c25518ff81dc967187497a0577f8ee2fb2e29.camel@redhat.com>
Date: Tue, 25 Nov 2025 10:53:18 -0600
From: Crystal Wood <crwood@...hat.com>
To: Wander Lairson Costa <wander@...hat.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, Tomas Glozar <tglozar@...hat.com>,
  Ivan Pravdin <ipravdin.official@...il.com>, John Kacur
 <jkacur@...hat.com>, Costa Shulyupin	 <costa.shul@...hat.com>, Tiezhu Yang
 <yangtiezhu@...ngson.cn>, "open list:Real-time Linux Analysis (RTLA) tools"
	 <linux-trace-kernel@...r.kernel.org>, open list
 <linux-kernel@...r.kernel.org>,  "open list:BPF
 [MISC]:Keyword:(?:\\b|_)bpf(?:\\b|_)"	 <bpf@...r.kernel.org>
Subject: Re: [rtla 05/13] rtla: Simplify argument parsing

On Tue, 2025-11-25 at 10:45 -0300, Wander Lairson Costa wrote:
> On Mon, Nov 24, 2025 at 06:46:33PM -0600, Crystal Wood wrote:
> > On Mon, 2025-11-17 at 15:41 -0300, Wander Lairson Costa wrote:
> > > diff --git a/tools/tracing/rtla/src/utils.h b/tools/tracing/rtla/src/utils.h
> > > index 160491f5de91c..f7ff548f7fba7 100644
> > > --- a/tools/tracing/rtla/src/utils.h
> > > +++ b/tools/tracing/rtla/src/utils.h
> > > @@ -13,8 +13,18 @@
> > >  #define MAX_NICE		20
> > >  #define MIN_NICE		-19
> > >  
> > > -#define container_of(ptr, type, member)({			\
> > > -	const typeof(((type *)0)->member) *__mptr = (ptr);	\
> > [snip]
> > > +#define container_of(ptr, type, member)({				\
> > > +	const typeof(((type *)0)->member) *__mptr = (ptr);		\
> > >  	(type *)((char *)__mptr - offsetof(type, member)) ; })
> > 
> > It's easier to review patches when they don't make unrelated aesthetic
> > changes...
> > 
> 
> It is just git messing up the diff. No actual change.

The change was to the position of the backslashes.  Not a big deal, just
something that's helpful to avoid to get a cleaner diff.

-Crystal