linux-kernel - Re: [PATCH v6 2/2] spi: add driver for NXP XSPI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <519e20a0-8568-485e-a66d-04309ba0d43a@sirena.org.uk>
Date: Tue, 25 Nov 2025 17:51:12 +0000
From: Mark Brown <broonie@...nel.org>
To: Haibo Chen <haibo.chen@....com>
Cc: Han Xu <han.xu@....com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, linux-spi@...r.kernel.org,
	imx@...ts.linux.dev, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	frank.li@....com
Subject: Re: [PATCH v6 2/2] spi: add driver for NXP XSPI controller

On Tue, Nov 25, 2025 at 03:42:19PM +0800, Haibo Chen wrote:
> Add driver support for NXP XSPI controller.
> 
> XSPI is a flexible SPI host controller which supports up to
> 2 external devices (2 CS). It support Single/Dual/Quad/Octal
> mode data transfer.

This breaks the build:

/build/stage/linux/drivers/spi/spi-nxp-xspi.c: In function ‘nxp_xspi_exec_op’:
/build/stage/linux/drivers/spi/spi-nxp-xspi.c:997:9: error: implicit declaration
 of function ‘PM_RUNTIME_ACQUIRE_AUTOSUSPEND’ [-Wimplicit-function-declaration]
  997 |         PM_RUNTIME_ACQUIRE_AUTOSUSPEND(xspi->dev, pm);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/build/stage/linux/drivers/spi/spi-nxp-xspi.c:997:51: error: ‘pm’ undeclared (fi
rst use in this function); did you mean ‘tm’?
  997 |         PM_RUNTIME_ACQUIRE_AUTOSUSPEND(xspi->dev, pm);
      |                                                   ^~
      |                                                   tm
/build/stage/linux/drivers/spi/spi-nxp-xspi.c:997:51: note: each undeclared iden
tifier is reported only once for each function it appears in
/build/stage/linux/drivers/spi/spi-nxp-xspi.c:998:15: error: implicit declaration of function ‘PM_RUNTIME_ACQUIRE_ERR’ [-Wimplicit-function-declaration]
  998 |         err = PM_RUNTIME_ACQUIRE_ERR(&pm);
      |               ^~~~~~~~~~~~~~~~~~~~~~
/build/stage/linux/drivers/spi/spi-nxp-xspi.c: In function ‘nxp_xspi_probe’:
/build/stage/linux/drivers/spi/spi-nxp-xspi.c:1265:45: error: ‘pm’ undeclared (first use in this function); did you mean ‘tm’?
 1265 |         PM_RUNTIME_ACQUIRE_AUTOSUSPEND(dev, pm);
      |                                             ^~
      |                                             tm

Please resubmit after the merge window unless there's already a
convenient tag for the new macro.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)