linux-kernel - Re: [PATCH v1 1/1] cpuidle: Update header inclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jFm90q2uSmSzqwpTpqXbW2pOnqE9P_dbrYoSpee2=+8w@mail.gmail.com>
Date: Tue, 25 Nov 2025 19:05:31 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	"Rafael J. Wysocki" <rafael@...nel.org>, Daniel Lezcano <daniel.lezcano@...aro.org>
Subject: Re: [PATCH v1 1/1] cpuidle: Update header inclusion

On Mon, Nov 24, 2025 at 9:58 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> While cleaning up some headers, I got a build error on this file:
>
> drivers/cpuidle/poll_state.c:52:2: error: call to undeclared library function 'snprintf' with type 'int (char *restrict, unsigned long, const char *restrict, ...)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/cpuidle/poll_state.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/cpuidle/poll_state.c b/drivers/cpuidle/poll_state.c
> index 9b6d90a72601..c7524e4c522a 100644
> --- a/drivers/cpuidle/poll_state.c
> +++ b/drivers/cpuidle/poll_state.c
> @@ -4,9 +4,13 @@
>   */
>
>  #include <linux/cpuidle.h>
> +#include <linux/export.h>
> +#include <linux/irqflags.h>
>  #include <linux/sched.h>
>  #include <linux/sched/clock.h>
>  #include <linux/sched/idle.h>
> +#include <linux/sprintf.h>
> +#include <linux/types.h>
>
>  #define POLL_IDLE_RELAX_COUNT  200
>
> --

Applied as 6.19 material, thanks!