linux-kernel - Re: [PATCH V3 1/6] block: ignore discard return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a192b8dd-6d67-475c-972e-a88d6d8b8e5a@kernel.dk>
Date: Tue, 25 Nov 2025 12:19:10 -0700
From: Jens Axboe <axboe@...nel.dk>
To: Chaitanya Kulkarni <ckulkarnilinux@...il.com>, agk@...hat.com,
 snitzer@...nel.org, mpatocka@...hat.com, song@...nel.org, yukuai@...as.com,
 hch@....de, sagi@...mberg.me, kch@...dia.com, jaegeuk@...nel.org,
 chao@...nel.org, cem@...nel.org
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
 dm-devel@...ts.linux.dev, linux-raid@...r.kernel.org,
 linux-nvme@...ts.infradead.org, linux-f2fs-devel@...ts.sourceforge.net,
 linux-xfs@...r.kernel.org, bpf@...r.kernel.org,
 Johannes Thumshirn <johannes.thumshirn@....com>,
 "Martin K . Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH V3 1/6] block: ignore discard return value

On 11/25/25 12:09 PM, Chaitanya Kulkarni wrote:
> On 11/25/25 09:38, Jens Axboe wrote:
>> On 11/24/25 4:48 PM, Chaitanya Kulkarni wrote:
>>> __blkdev_issue_discard() always returns 0, making the error check
>>> in blkdev_issue_discard() dead code.
>> Shouldn't it be a void instead then?
>>
> Yes, we have decided to clean up the callers first [1]. Once they are
> merged safely, after rc1 I'll send a patch [2] to make it void since
> it touches many different subsystems.

OK, that make sense. I'll queue patch 1.

-- 
Jens Axboe