linux-kernel - Re: [RFC v1 2/4] pinctrl: add polarfire soc mssio pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251125-sauciness-those-49593f401322@spud>
Date: Tue, 25 Nov 2025 19:55:06 +0000
From: Conor Dooley <conor@...nel.org>
To: Linus Walleij <linusw@...nel.org>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Conor Dooley <conor.dooley@...rochip.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
	devicetree@...r.kernel.org, Valentina.FernandezAlanis@...rochip.com,
	Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [RFC v1 2/4] pinctrl: add polarfire soc mssio pinctrl driver

On Tue, Nov 25, 2025 at 08:28:10PM +0100, Linus Walleij wrote:
> On Tue, Nov 25, 2025 at 6:47 PM Conor Dooley <conor@...nel.org> wrote:

> > > > It seems to depend on aml_pctl_parse_functions() being called
> > > > during probe which creates the groups and functions.
> > > > There's a weird warning about expecting a function parent node that seems
> > > > very amlogic specific too.
> > > >
> > > > In my eyes, there should be some generic dt_node_to_map helpers that
> > > > do it all for you on the "configuration entirely described in dt"
> > > > platforms because that's what stuff like spacemit k1 driver that do
> > > > this in their dt_node_to_map implementations.
> > >
> > > I think you're right!
> >
> > My dilemma now is what to call them and where to put them.
> > pinconf_generic_dt_node_to_map<something>() feels weird for something
> > that is also creating functions and groups, which I noticed because I
> > was having to include pinmux.h in pinconf.c so that I could call
> > pinmux_generic_add_function().
> 
> pinctrl_generic_dt_node_parse_config() or so? Is it vague enough?

Probably too vague, since it's gonna be pins + functions specific, but
I'll do something along these lines. Where should I put it? Leave it in
pinconf-generic, but do some gating of it to only be exposed for configs
with GENERIC_PINMUX_FUNCTIONS enabled?

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)