linux-kernel - Re: [PATCH 2/2] tracing: Merge struct event_trigger_ops into struct event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251125150504.407ebbc2@gandalf.local.home>
Date: Tue, 25 Nov 2025 15:05:04 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Tom Zanussi <zanussi@...nel.org>
Cc: Steven Rostedt <rostedt@...nel.org>, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, Masami Hiramatsu <mhiramat@...nel.org>,
 Mark Rutland <mark.rutland@....com>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/2] tracing: Merge struct event_trigger_ops into struct
 event_command

On Tue, 25 Nov 2025 07:01:43 -0600
Tom Zanussi <zanussi@...nel.org> wrote:

> > -static const struct event_trigger_ops event_hist_trigger_ops = {
> > -	.trigger		= event_hist_trigger,
> > -	.print			= event_hist_trigger_print,
> > -	.init			= event_hist_trigger_init,
> > -	.free			= event_hist_trigger_free,
> > -};
> > +static struct event_command trigger_hist_cmd;
> >    
> 
> I don't think this is needed, since the same declaration already
> appears just above the event_hist_trigger_parse() declaration.

No it doesn't. Nice catch. I'll send a v2.

Thanks for the review.

-- Steve