linux-kernel - Re: [PATCH 1/3] Corrected errno in minix_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2011101200.2783646.1764106468187@kpc.webmail.kpnmail.nl>
Date: Tue, 25 Nov 2025 22:34:28 +0100 (CET)
From: Jori Koolstra <jkoolstra@...all.nl>
To: Jan Kara <jack@...e.cz>
Cc: Christian Brauner <brauner@...nel.org>,
	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
	Taotao Chen <chentaotao@...iglobal.com>,
	Shuah Khan <skhan@...uxfoundation.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] Corrected errno in minix_new_inode


> 
> OK, but this will make the compiler likely unhappy (because it doesn't know
> s_imap_blocks cannot be 0) and generally the code will be less
> self-containted. So in the spirit of defensive programming I'd leave the
> assignment there.
> 

OK, I see. I agree. Still should it then not be set where j is declared? But
that is a very minor point. I am okay with removing that change.

PS. Sorry, I forgot to send-all. My apologies for the double emails.