linux-kernel - Re: [PATCH 3/3] tools/power turbostat: allow turbostat to work when aperf is not available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b2ff2579-0d19-4648-9411-c02133c28c1d@redhat.com>
Date: Tue, 25 Nov 2025 16:55:57 -0500
From: David Arcari <darcari@...hat.com>
To: Len Brown <lenb@...nel.org>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] tools/power turbostat: allow turbostat to work when
 aperf is not available



On 11/25/25 2:14 PM, Len Brown wrote:
> It would be helpful if you could describe exactly what environment you
> are running in.

It' a VMWARE instance.

CPUID(0): AuthenticAMD 0xd CPUID levels
CPUID(1): family:model:stepping 0x17:0:0 (23:0:0) microcode 0x0
CPUID(0x80000000): max_extended_levels: 0x8000001f
CPUID(1): SSE3 - - - - TSC MSR - - -
CPUID(6): No-APERF, No-TURBO, No-DTS, No-PTM, No-HWP, No-HWPnotify, 
No-HWPwindow, No-HWPepp, No-HWPpkg, No-EPB
CPUID(7): No-SGX No-Hybrid


> 
> are there any MSRs?

I'm not certain, is there something in particular you are looking for?

> Is APERF available via perf, but not via MSR?
> etc.

I don't believe that APERF was available via perf. I'll go back and 
verify when I have a chance.

-DA

> 
> On Tue, Nov 18, 2025 at 10:58 AM David Arcari <darcari@...hat.com> wrote:
>>
>> Currently when aperf is not available the function has_amperf() still
>> returns true.  The end result is that the program gets an error in
>> delta_thread() which causes turbostat to restart.  We can avoid this
>> by not setting msr_counter_arch_infos[MSR_ARCH_INFO_APERF_INDEX].present
>> when aperf is not available allowing turbostat to execute normally.
>>
>> Signed-off-by: David Arcari <darcari@...hat.com>
>> Cc: Len Brown <lenb@...nel.org>
>> Cc: linux-kernel@...r.kernel.org
>> ---
>>   tools/power/x86/turbostat/turbostat.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
>> index 5567b9ecd516..b3f1e4ae5813 100644
>> --- a/tools/power/x86/turbostat/turbostat.c
>> +++ b/tools/power/x86/turbostat/turbostat.c
>> @@ -8592,6 +8592,10 @@ void msr_perf_init_(void)
>>                                  continue;
>>
>>                          if (cai->needed) {
>> +                               /* check to see if APERF is available */
>> +                               if (cidx == MSR_ARCH_INFO_APERF_INDEX && !has_aperf)
>> +                                       continue;
>> +
>>                                  /* Use perf API for this counter */
>>                                  if (add_msr_perf_counter(cpu, cci, cai) != -1) {
>>                                          cci->source[cai->rci_index] = COUNTER_SOURCE_PERF;
>> --
>> 2.51.0
>>
>>
> 
>