linux-kernel - Re: [PATCH net-next 1/1] net: mdio: remove redundant fwnode cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8adc81c3-7f61-4148-9ec6-ef69d0988b4b@lunn.ch>
Date: Wed, 26 Nov 2025 00:10:13 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Buday Csaba <buday.csaba@...lan.hu>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/1] net: mdio: remove redundant fwnode cleanup

On Mon, Nov 24, 2025 at 03:50:44PM +0100, Buday Csaba wrote:
> Remove redundant fwnode cleanup in of_mdiobus_register_device()
> and xpcs_plat_init_dev().
> 
> mdio_device_free() eventually calls mdio_device_release(),
> which already performs fwnode_handle_put(), making the manual
> cleanup unnecessary.
> 
> Combine fwnode_handle_get() with device_set_node() in
> of_mdiobus_register_device() for clarity.
> 
> Signed-off-by: Buday Csaba <buday.csaba@...lan.hu>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew