linux-kernel - Re: [PATCH v3 3/6] pmdomain: Respect the CPU system wakeup QoS limit for cpuidle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251125052859.ircunrhwwwnpw7pl@lcpd911>
Date: Tue, 25 Nov 2025 10:58:59 +0530
From: Dhruva Gole <d-gole@...com>
To: Ulf Hansson <ulf.hansson@...aro.org>
CC: "Rafael J . Wysocki" <rafael@...nel.org>, <linux-pm@...r.kernel.org>,
	Vincent Guittot <vincent.guittot@...aro.org>, Peter Zijlstra
	<peterz@...radead.org>, Kevin Hilman <khilman@...libre.com>, Pavel Machek
	<pavel@...nel.org>, Len Brown <len.brown@...el.com>, Daniel Lezcano
	<daniel.lezcano@...aro.org>, Maulik Shah <quic_mkshah@...cinc.com>, "Prasad
 Sodagudi" <psodagud@...cinc.com>, Deepti Jaggi <quic_djaggi@...cinc.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 3/6] pmdomain: Respect the CPU system wakeup QoS limit
 for cpuidle

On Nov 21, 2025 at 11:03:09 +0100, Ulf Hansson wrote:
> The CPU system wakeup QoS limit must be respected for the regular cpuidle
> state selection. Therefore, let's extend the genpd governor for CPUs to
> take the constraint into account when it selects a domain idle state for
> the corresponding PM domain.
> 
> Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>
> ---
> 
> Changes in v3:
> 	- New patch.
> 
> ---
>  drivers/pmdomain/governor.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pmdomain/governor.c b/drivers/pmdomain/governor.c
> index bd1b9d66d4a5..05e68680f34b 100644
> --- a/drivers/pmdomain/governor.c
> +++ b/drivers/pmdomain/governor.c
> @@ -351,7 +351,7 @@ static bool cpu_power_down_ok(struct dev_pm_domain *pd)
>  	ktime_t domain_wakeup, next_hrtimer;
>  	ktime_t now = ktime_get();
>  	struct device *cpu_dev;
> -	s64 cpu_constraint, global_constraint;
> +	s64 cpu_constraint, global_constraint, wakeup_constraint;
>  	s64 idle_duration_ns;
>  	int cpu, i;
>  
> @@ -362,7 +362,11 @@ static bool cpu_power_down_ok(struct dev_pm_domain *pd)
>  	if (!(genpd->flags & GENPD_FLAG_CPU_DOMAIN))
>  		return true;
>  
> +	wakeup_constraint = cpu_wakeup_latency_qos_limit();
>  	global_constraint = cpu_latency_qos_limit();
> +	if (global_constraint > wakeup_constraint)
> +		global_constraint = wakeup_constraint;
> +

Reviewed-by: Dhruva Gole <d-gole@...com>

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated