linux-kernel - Re: [PATCH v3 5/6] cpuidle: Respect the CPU system wakeup QoS limit for cpuidle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251125054115.7y26ize7h5kqhe5l@lcpd911>
Date: Tue, 25 Nov 2025 11:11:15 +0530
From: Dhruva Gole <d-gole@...com>
To: Ulf Hansson <ulf.hansson@...aro.org>
CC: "Rafael J . Wysocki" <rafael@...nel.org>, <linux-pm@...r.kernel.org>,
	Vincent Guittot <vincent.guittot@...aro.org>, Peter Zijlstra
	<peterz@...radead.org>, Kevin Hilman <khilman@...libre.com>, Pavel Machek
	<pavel@...nel.org>, Len Brown <len.brown@...el.com>, Daniel Lezcano
	<daniel.lezcano@...aro.org>, Maulik Shah <quic_mkshah@...cinc.com>, "Prasad
 Sodagudi" <psodagud@...cinc.com>, Deepti Jaggi <quic_djaggi@...cinc.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 5/6] cpuidle: Respect the CPU system wakeup QoS limit
 for cpuidle

On Nov 21, 2025 at 11:03:11 +0100, Ulf Hansson wrote:
> The CPU system wakeup QoS limit must be respected for the regular cpuidle
> state selection. Therefore, let's extend the common governor helper
> cpuidle_governor_latency_req(), to take the constraint into account.
> 
> Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>
> ---

Reviewed-by: Dhruva Gole <d-gole@...com>

> 
> Changes in v3:
> 	- New patch.
> 
> ---
>  drivers/cpuidle/governor.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/cpuidle/governor.c b/drivers/cpuidle/governor.c
> index 0d0f9751ff8f..5d0e7f78c6c5 100644
> --- a/drivers/cpuidle/governor.c
> +++ b/drivers/cpuidle/governor.c
> @@ -111,6 +111,10 @@ s64 cpuidle_governor_latency_req(unsigned int cpu)
>  	struct device *device = get_cpu_device(cpu);
>  	int device_req = dev_pm_qos_raw_resume_latency(device);
>  	int global_req = cpu_latency_qos_limit();
> +	int global_wake_req = cpu_wakeup_latency_qos_limit();
> +
> +	if (global_req > global_wake_req)
> +		global_req = global_wake_req;
>  
>  	if (device_req > global_req)
>  		device_req = global_req;
> -- 
> 2.43.0
> 

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated