linux-kernel - RE: [Intel-wired-lan] [PATCH net-next 7/8] ixgbevf: extract GRXRINGS from .get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986482A0850CF0F03970F63E5D1A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Tue, 25 Nov 2025 06:48:55 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Breno Leitao <leitao@...ian.org>, "Lobakin, Aleksander"
	<aleksander.lobakin@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
CC: "michal.swiatkowski@...ux.intel.com" <michal.swiatkowski@...ux.intel.com>,
	"michal.kubiak@...el.com" <michal.kubiak@...el.com>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kernel-team@...a.com" <kernel-team@...a.com>
Subject: RE: [Intel-wired-lan] [PATCH net-next 7/8] ixgbevf: extract GRXRINGS
 from .get_rxnfc



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Breno Leitao
> Sent: Monday, November 24, 2025 7:19 PM
> To: Lobakin, Aleksander <aleksander.lobakin@...el.com>; Nguyen,
> Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Andrew Lunn <andrew+netdev@...n.ch>;
> David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>
> Cc: michal.swiatkowski@...ux.intel.com; michal.kubiak@...el.com;
> Fijalkowski, Maciej <maciej.fijalkowski@...el.com>; intel-wired-
> lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; kernel-team@...a.com; Breno Leitao
> <leitao@...ian.org>
> Subject: [Intel-wired-lan] [PATCH net-next 7/8] ixgbevf: extract
> GRXRINGS from .get_rxnfc
> 
> Commit 84eaf4359c36 ("net: ethtool: add get_rx_ring_count callback to
> optimize RX ring queries") added specific support for GRXRINGS
> callback, simplifying .get_rxnfc.
> 
> Remove the handling of GRXRINGS in .get_rxnfc() by moving it to the
> new .get_rx_ring_count().
> 
> This simplifies the RX ring count retrieval and aligns ixgbevf with
> the new ethtool API for querying RX ring parameters.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>
> ---
>  drivers/net/ethernet/intel/ixgbevf/ethtool.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ethtool.c
> b/drivers/net/ethernet/intel/ixgbevf/ethtool.c
> index bebad564188e..537a60d5276f 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ethtool.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/ethtool.c
> @@ -867,19 +867,11 @@ static int ixgbevf_set_coalesce(struct
> net_device *netdev,
>  	return 0;
>  }
> 
> -static int ixgbevf_get_rxnfc(struct net_device *dev, struct
> ethtool_rxnfc *info,
> -			     u32 *rules __always_unused)
> +static u32 ixgbevf_get_rx_ring_count(struct net_device *dev)
>  {
>  	struct ixgbevf_adapter *adapter = netdev_priv(dev);
> 
> -	switch (info->cmd) {
> -	case ETHTOOL_GRXRINGS:
> -		info->data = adapter->num_rx_queues;
> -		return 0;
> -	default:
> -		hw_dbg(&adapter->hw, "Command parameters not
> supported\n");
> -		return -EOPNOTSUPP;
> -	}
> +	return adapter->num_rx_queues;
>  }
> 
>  static u32 ixgbevf_get_rxfh_indir_size(struct net_device *netdev) @@
> -987,7 +979,7 @@ static const struct ethtool_ops ixgbevf_ethtool_ops =
> {
>  	.get_ethtool_stats	= ixgbevf_get_ethtool_stats,
>  	.get_coalesce		= ixgbevf_get_coalesce,
>  	.set_coalesce		= ixgbevf_set_coalesce,
> -	.get_rxnfc		= ixgbevf_get_rxnfc,
> +	.get_rx_ring_count	= ixgbevf_get_rx_ring_count,
>  	.get_rxfh_indir_size	= ixgbevf_get_rxfh_indir_size,
>  	.get_rxfh_key_size	= ixgbevf_get_rxfh_key_size,
>  	.get_rxfh		= ixgbevf_get_rxfh,
> 
> --
> 2.47.3

Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>