linux-kernel - [PATCH net-next 1/3] net: Introduce netif_xmit_time_out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1764054776-1308696-2-git-send-email-tariqt@nvidia.com>
Date: Tue, 25 Nov 2025 09:12:54 +0200
From: Tariq Toukan <tariqt@...dia.com>
To: Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>
CC: Jian Shen <shenjian15@...wei.com>, Salil Mehta <salil.mehta@...wei.com>,
	Jijie Shao <shaojijie@...wei.com>, Saeed Mahameed <saeedm@...dia.com>, "Tariq
 Toukan" <tariqt@...dia.com>, Mark Bloch <mbloch@...dia.com>, Leon Romanovsky
	<leon@...nel.org>, Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang
	<xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-rdma@...r.kernel.org>, Gal Pressman <gal@...dia.com>, Moshe Shemesh
	<moshe@...dia.com>, Yael Chemla <ychemla@...dia.com>, Shahar Shitrit
	<shshitrit@...dia.com>
Subject: [PATCH net-next 1/3] net: Introduce netif_xmit_time_out_duration() helper

From: Shahar Shitrit <shshitrit@...dia.com>

Introduce a new helper function netif_xmit_time_out_duration() to
check if a TX queue has timed out and report the timeout duration.
This helper consolidates the logic that is duplicated in several
locations and also encapsulates the check for whether the TX queue
is stopped.

As the first user, convert dev_watchdog() to use this helper.

Signed-off-by: Shahar Shitrit <shshitrit@...dia.com>
Reviewed-by: Yael Chemla <ychemla@...dia.com>
Signed-off-by: Tariq Toukan <tariqt@...dia.com>
---
 include/linux/netdevice.h | 15 +++++++++++++++
 net/sched/sch_generic.c   |  7 +++----
 2 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index e808071dbb7d..3cd73769fcfa 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -3680,6 +3680,21 @@ static inline bool netif_xmit_stopped(const struct netdev_queue *dev_queue)
 	return dev_queue->state & QUEUE_STATE_ANY_XOFF;
 }
 
+static inline unsigned int
+netif_xmit_timeout_ms(struct netdev_queue *txq, unsigned long *trans_start)
+{
+	unsigned long txq_trans_start = READ_ONCE(txq->trans_start);
+
+	if (trans_start)
+		*trans_start = txq_trans_start;
+
+	if (netif_xmit_stopped(txq) &&
+	    time_after(jiffies, txq_trans_start + txq->dev->watchdog_timeo))
+		return jiffies_to_msecs(jiffies - txq_trans_start);
+
+	return 0;
+}
+
 static inline bool
 netif_xmit_frozen_or_stopped(const struct netdev_queue *dev_queue)
 {
diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
index 852e603c1755..aa6192781a24 100644
--- a/net/sched/sch_generic.c
+++ b/net/sched/sch_generic.c
@@ -523,10 +523,9 @@ static void dev_watchdog(struct timer_list *t)
 				 * netdev_tx_sent_queue() and netif_tx_stop_queue().
 				 */
 				smp_mb();
-				trans_start = READ_ONCE(txq->trans_start);
-
-				if (time_after(jiffies, trans_start + dev->watchdog_timeo)) {
-					timedout_ms = jiffies_to_msecs(jiffies - trans_start);
+				timedout_ms = netif_xmit_timeout_ms(txq,
+								    &trans_start);
+				if (timedout_ms) {
 					atomic_long_inc(&txq->trans_timeout);
 					break;
 				}
-- 
2.31.1