linux-kernel - Re: [PATCH 2/2] ARM: dts: Add support for pcb8385

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251125074236.bf7wms6djtcy3ymq@DEN-DL-M31836.microchip.com>
Date: Tue, 25 Nov 2025 08:42:36 +0100
From: Horatiu Vultur <horatiu.vultur@...rochip.com>
To: Claudiu Beznea <claudiu.beznea@...on.dev>
CC: <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
	<nicolas.ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
	<wsa+renesas@...g-engineering.com>, <romain.sioen@...rochip.com>,
	<devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] ARM: dts: Add support for pcb8385

The 11/22/2025 16:21, Claudiu Beznea wrote:
> 
> Hi, Horatiu,

Hi Claudiu,

> 

> > +&flx0 {
> 
> This would go after aes node to have them alphanumerically sorted. I can
> handled it while applying, if any.

Yes, I make sure that the nodes are sorted alphanumerically.

> 
> > +     atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_TWI>;
> > +     status = "okay";
> > +
> > +     i2c0: i2c@600 {
> > +             pinctrl-0 = <&fc0_b_pins>;
> > +             pinctrl-names = "default";
> > +             dmas = <0>, <0>;
> > +             i2c-analog-filter;
> > +             i2c-digital-filter;
> > +             i2c-digital-filter-width-ns = <35>;
> > +             i2c-sda-hold-time-ns = <1500>;
> > +             status = "okay";
> > +     };
> > +};

...

> > +&i2c0 {
> > +     eeprom@54 {
> > +             compatible = "atmel,24c01";
> > +             reg = <0x54>;
> > +             status = "okay";
> > +     };
> > +
> > +     eeprom@55 {
> > +             compatible = "atmel,24c01";
> > +             reg = <0x55>;
> > +             status = "okay";
> > +     };
> 
> Any reason for not keeping these above under "i2c0: i2c@600 {" ?

Not really. I will move them there.

> 
> Thank you,
> Claudiu
> 
> > +};
> > +
> > +&sgpio {
> > +     pinctrl-0 = <&sgpio_a_pins>;
> > +     pinctrl-names = "default";
> > +     microchip,sgpio-port-ranges = <0 3>;
> > +     status = "okay";
> > +
> > +     gpio@0 {
> > +             ngpios = <64>;
> > +     };
> > +     gpio@1 {
> > +             ngpios = <64>;
> > +     };
> > +};
> 

-- 
/Horatiu