linux-kernel - Re: [PATCH] gpu: Move DRM buddy allocator one level up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24d4f02b-8ecd-4512-a1f0-ba41684ede1d@amd.com>
Date: Tue, 25 Nov 2025 08:54:35 +0100
From: Christian König <christian.koenig@....com>
To: Dave Airlie <airlied@...il.com>
Cc: Joel Fernandes <joelagnelf@...dia.com>, linux-kernel@...r.kernel.org,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Simona Vetter <simona@...ll.ch>, Jonathan Corbet <corbet@....net>,
 Alex Deucher <alexander.deucher@....com>,
 Jani Nikula <jani.nikula@...ux.intel.com>,
 Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
 Rodrigo Vivi <rodrigo.vivi@...el.com>, Tvrtko Ursulin
 <tursulin@...ulin.net>, Huang Rui <ray.huang@....com>,
 Matthew Auld <matthew.auld@...el.com>,
 Matthew Brost <matthew.brost@...el.com>,
 Lucas De Marchi <lucas.demarchi@...el.com>,
 Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
 Helge Deller <deller@....de>, Danilo Krummrich <dakr@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>, Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>, Trevor Gross <tmgross@...ch.edu>,
 John Hubbard <jhubbard@...dia.com>, Alistair Popple <apopple@...dia.com>,
 Timur Tabi <ttabi@...dia.com>, Edwin Peer <epeer@...dia.com>,
 Alexandre Courbot <acourbot@...dia.com>, nouveau@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, rust-for-linux@...r.kernel.org,
 linux-doc@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
 intel-gfx@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org,
 linux-fbdev@...r.kernel.org
Subject: Re: [PATCH] gpu: Move DRM buddy allocator one level up

On 11/25/25 08:49, Dave Airlie wrote:
> On Tue, 25 Nov 2025 at 17:45, Christian König <christian.koenig@....com> wrote:
>>
>> On 11/25/25 00:44, Joel Fernandes wrote:
>>> Move the DRM buddy allocator one level up so that it can be used by GPU
>>> drivers (example, nova-core) that have usecases other than DRM (such as
>>> VFIO vGPU support). Modify the API, structures and Kconfigs to use
>>> "gpu_buddy" terminology. Adapt the drivers and tests to use the new API.
>>>
>>> The commit cannot be split due to bissectability, however no functional
>>> change is intended. Verified by running K-UNIT tests and build tested
>>> various configurations.
>>
>> Well such a change needs to be part of the patch set which actually starts to use it outside of drivers/gpu/drm.
> 
> I'm not sure it really makes sense yet to force that for this, since
> the next patch would be just adding rust bindings to it, then a patch
> to nova-core would be needed to use it, I'd rather not merge something
> like this via the rust or nova trees as it breaks the principle of
> least surprise.
> 
> Maybe this + rust bindings might be enough to justify it, but it
> should be reviewable as a standalone idea.

My question is why exactly is nova separated into nova-core and nova-drm? That doesn't seem to be necessary in the first place.

E.g. neither amdgpu not XE need that and we are doing pretty much the same thing.

Regards,
Christian.

> 
> Dave.