linux-kernel - Re: [PATCH v3 1/2] dt-bindings: riscv: starfive: add xunlong,orangepi-rv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a2104faee332ee143b5499c18aea3625971156c.camel@icenowy.me>
Date: Tue, 25 Nov 2025 16:01:40 +0800
From: Icenowy Zheng <uwu@...nowy.me>
To: Krzysztof Kozlowski <krzk@...nel.org>, E Shattow <e@...eshell.de>, Conor
	Dooley <conor@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
  Conor Dooley <conor+dt@...nel.org>, Paul Walmsley <pjw@...nel.org>, Palmer
 Dabbelt <palmer@...belt.com>,  Albert Ou <aou@...s.berkeley.edu>, Alexandre
 Ghiti <alex@...ti.fr>, Michael Zhu <michael.zhu@...rfivetech.com>, Drew
 Fustini <drew@...gleboard.org>,  linux-kernel@...r.kernel.org,
 linux-riscv@...ts.infradead.org,  devicetree@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: riscv: starfive: add
 xunlong,orangepi-rv

在 2025-11-25星期二的 08:48 +0100，Krzysztof Kozlowski写道：
> On 25/11/2025 08:33, Icenowy Zheng wrote:
> > 在 2025-11-25星期二的 08:28 +0100，Krzysztof Kozlowski写道：
> > > On 24/11/2025 22:59, E Shattow wrote:
> > > > 
> > > > On 11/24/25 05:22, Conor Dooley wrote:
> > > > > On Mon, Nov 24, 2025 at 08:28:10AM +0100, Krzysztof Kozlowski
> > > > > wrote:
> > > > > > On Sun, Nov 23, 2025 at 02:50:44PM -0800, E Shattow wrote:
> > > > > > > From: Icenowy Zheng <uwu@...nowy.me>
> > > > > > > 
> > > > > > > Add "xunlong,orangepi-rv" as a StarFive JH7110 SoC-based
> > > > > > > board.
> > > > > > > 
> > > > > > > Signed-off-by: Icenowy Zheng <uwu@...nowy.me>
> > > > > > > Signed-off-by: E Shattow <e@...eshell.de>
> > > > > > 
> > > > > > <form letter>
> > > > > > This is a friendly reminder during the review process.
> > > > > > 
> > > > > > It looks like you received a tag and forgot to add it.
> > > > > 
> > > > > It's from me, don't resubmit just to add it since it'll be me
> > > > > applying
> > > > > anyway.
> > > > > 
> > > > 
> > > > Hi Conor,
> > > > 
> > > > Okay. Yes I'd dropped the tag since the commit message is
> > > > appreciably
> > > > different, and you would be handling it again anyways. Thanks!
> > > > And
> > > > thank
> > > > you Krzysztof for the reminder -E
> > > 
> > > 
> > > And where did you explain that you dropped the tag because of
> > > that?
> > > Please read the form letter carefully.
> > 
> > Well I think there's no clear definition of "the patch has changed
> > substantially" here.
> > 
> > E may think for this such-short patch, the commit message weighs a
> > lot
> > and the change to it is significant to the patch (e.g. making the
> > patch
> > not clear enough).
> 
> You still did not bother to read what we expect. I do not discuss if
> this changed significantly or not, although it is obvious that it did
> not change and tag should have been retained.
> 
> Look again:
> <QUOTE>
> Please read:
> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
> 
> If a tag was not added on purpose, please state why and what changed.
> </QUOTE>
> 
> Where did you explain that?

Sure, I agree that explaination of this should be delivered.

> 
> 
> Best regards,
> Krzysztof