linux-kernel - Re: [PATCH v2] platform/x86: serial-multi-instantiate: IRQ_RESOURCE_AUTO should be compatible with IRQ_RESOURCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSV190mwCKZ6WOoA@smile.fi.intel.com>
Date: Tue, 25 Nov 2025 11:25:11 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Baojun Xu <baojun.xu@...com>
Cc: tiwai@...e.de, hansg@...nel.org, ilpo.jarvinen@...ux.intel.com,
	broonie@...nel.org, alsa-devel@...a-project.org,
	shenghao-ding@...com, 13916275206@....com,
	platform-driver-x86@...r.kernel.org, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org, letitia.tsai@...com
Subject: Re: [PATCH v2] platform/x86: serial-multi-instantiate:
 IRQ_RESOURCE_AUTO should be compatible with IRQ_RESOURCE_NONE

On Tue, Nov 25, 2025 at 04:44:36PM +0800, Baojun Xu wrote:
> The tas2781-hda supports multi-projects, in some projects,
> no irq is required, so the IRQ_RESOURCE_AUTO should be compatible
> with IRQ_RESOURCE_NONE.

TL;DR: NAK.

It will relax the conditions for the devices where IRQ is required.
Probably you need to consider DMI quirks or so.

Also you failed to provide the ACPI DSDT excerpts to show the real use case.
And what the board is that that uses polling mode?

You can also consider this approach (as a compromise between two:

#define IRQ_RESOURCE_OPTIONAL	BIT(2)
...
	switch (inst->flags & IRQ_RESOURCE_TYPE) {
	case IRQ_RESOURCE_AUTO:
		...
		if (inst->flags & IRQ_RESOURCE_OPTIONAL)
			ret = 0;
	break;
	...
	}
...
		{ "tas2781-hda", IRQ_RESOURCE_AUTO | IRQ_RESOURCE_OPTIONAL, 0 },


-- 
With Best Regards,
Andy Shevchenko