linux-kernel - Re: [PATCH 0/2] Enable Inline crypto engine for kodiak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251125-inquisitive-sincere-mustang-adfcde@kuoka>
Date: Tue, 25 Nov 2025 11:04:15 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Neeraj Soni <neeraj.soni@....qualcomm.com>
Cc: Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org, 
	conor+dt@...nel.org, andersson@...nel.org, linux-kernel@...r.kernel.org, 
	krzk+dt@...nel.org, konradybcio@...nel.org, linux-mmc@...r.kernel.org, 
	ulf.hansson@...aro.org
Subject: Re: [PATCH 0/2] Enable Inline crypto engine for kodiak

On Tue, Nov 25, 2025 at 10:28:16AM +0530, Neeraj Soni wrote:
> Hi,
> 
> On 11/24/2025 7:58 PM, Rob Herring wrote:
> > 
> > On Mon, 24 Nov 2025 16:49:12 +0530, Neeraj Soni wrote:
> >> Document Inline Crypto Engine (ICE) handle for SDHC and add its device-tree
> >> node to enable it for kodiak.
> >>
> >> Neeraj Soni (2):
> >>   dt-bindings: mmc: sdhci-msm: Add ICE phandle
> >>   arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC
> >>
> >>  .../devicetree/bindings/mmc/sdhci-msm.yaml    | 38 +++++++++++++++++++
> >>  arch/arm64/boot/dts/qcom/kodiak.dtsi          |  9 +++++
> >>  2 files changed, 47 insertions(+)
> >>
> >> --
> >> 2.34.1
> >>
> >>
> >>
> > 
> > 
> > My bot found new DTB warnings on the .dts files added or changed in this
> > series.
> > 
> > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> > are fixed by another series. Ultimately, it is up to the platform
> > maintainer whether these warnings are acceptable or not. No need to reply
> > unless the platform maintainer has comments.
> > 
> > If you already ran DT checks and didn't see these error(s), then
> > make sure dt-schema is up to date:
> > 
> >   pip3 install dtschema --upgrade
> yes i had tested this patch by running these:
> pip install dtschema
> make DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/sdhci-msm.yaml dt_binding_check
> make dtbs_check
> but did not see the below errors. I will upgrade and re-run the commands to check these. 

You did not do basic DTS testing, because your code have obvious DTC
errors. The error is even printed here by Rob's bot, but the point is
that you had to do testing of your DTS and it did not happen.

Best regards,
Krzysztof