linux-kernel - [PATCH] arm64: dts: mediatek: mt8365-evk: Fix touchscreen reset line polarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20251125-mtk8365-evk-touchscreen-rst-pin-v1-1-316facb96d63@collabora.com>
Date: Tue, 25 Nov 2025 11:28:27 +0100
From: Louis-Alexis Eyraud <louisalexis.eyraud@...labora.com>
To: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Conor Dooley <conor+dt@...nel.org>, 
 Matthias Brugger <matthias.bgg@...il.com>, 
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
 Hans de Goede <hansg@...nel.org>, Martyn Welch <martyn.welch@...labora.com>, 
 Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: kernel@...labora.com, devicetree@...r.kernel.org, 
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
 linux-mediatek@...ts.infradead.org, 
 Louis-Alexis Eyraud <louisalexis.eyraud@...labora.com>
Subject: [PATCH] arm64: dts: mediatek: mt8365-evk: Fix touchscreen reset
 line polarity

Commit 7363096a5a08 ("Input: goodix - remove setting of RST pin to input")
modified the Goodix driver so it no longer tries to set reset pin as
input.

It led the driver to fail to probe during boot time on the Mediatek
Genio 350-EVK board because the reset pin polarity is incorrectly
declared in the board devicetree:
```
[    6.253819] Goodix-TS 1-005d: Error reading 1 bytes from 0x8140: -6
[    6.277884] Goodix-TS 1-005d: Error reading 1 bytes from 0x8140: -6
[    6.305503] Goodix-TS 1-005d: I2C communication failure: -6
```

so fix in the mt8365-evk.dts the reset-gpios property and pinctrl
configuration of the touchscreen node to use the proper polarity value.

Fixes: 7363096a5a08 ("Input: goodix - remove setting of RST pin to input")
Fixes: b28c4af8e44b ("arm64: dts: mt8365-evk: Add goodix touchscreen support")
Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@...labora.com>
---
Patch tested on Mediatek Genio 350-EVK board with kernels based on
linux-next (tag: 20251125) and v6.18-rc7.
---
 arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts
index b5dd5ef9fa11ae1d54aa754325bac2e184b90dd3..4aa802ba85ce541f57ffed439262c15e1d7bcfe3 100644
--- a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts
@@ -352,7 +352,7 @@ touchscreen@5d {
 		pinctrl-names = "default";
 		pinctrl-0 = <&touch_pins>;
 		irq-gpios = <&pio 78 GPIO_ACTIVE_HIGH>;
-		reset-gpios = <&pio 79 GPIO_ACTIVE_LOW>;
+		reset-gpios = <&pio 79 GPIO_ACTIVE_HIGH>;
 		AVDD28-supply = <&touch0_fixed_3v3>;
 		VDDIO-supply = <&mt6357_vrf12_reg>;
 	};
@@ -695,7 +695,7 @@ ctp-int1-pins {
 
 		rst-pins {
 			pinmux = <MT8365_PIN_79_CMVSYNC__FUNC_GPIO79>;
-			output-low;
+			output-high;
 		};
 	};
 

---
base-commit: acb2ca6959161544908b4ad1537b0b70c80f052f
change-id: 20251125-mtk8365-evk-touchscreen-rst-pin-c6f30631582e

Best regards,
-- 
Louis-Alexis Eyraud <louisalexis.eyraud@...labora.com>