linux-kernel - Re: [Patch net-next v3] net: mana: Handle hardware recovery events when probing the device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSWKLefd_mhycGDv@horms.kernel.org>
Date: Tue, 25 Nov 2025 10:51:25 +0000
From: Simon Horman <horms@...nel.org>
To: longli@...ux.microsoft.com
Cc: "K. Y. Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Shradha Gupta <shradhagupta@...ux.microsoft.com>,
	Konstantin Taranov <kotaranov@...rosoft.com>,
	Souradeep Chakrabarti <schakrabarti@...ux.microsoft.com>,
	Erick Archer <erick.archer@...look.com>,
	linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
	Long Li <longli@...rosoft.com>
Subject: Re: [Patch net-next v3] net: mana: Handle hardware recovery events
 when probing the device

On Thu, Nov 20, 2025 at 03:07:13PM -0800, longli@...ux.microsoft.com wrote:
> From: Long Li <longli@...rosoft.com>
> 
> When MANA is being probed, it's possible that hardware is in recovery
> mode and the device may get GDMA_EQE_HWC_RESET_REQUEST over HWC in the
> middle of the probe. Detect such condition and go through the recovery
> service procedure.
> 
> Fixes: fbe346ce9d62 ("net: mana: Handle Reset Request from MANA NIC")

If this is a fix, should it be targeted at net rather than net-next?

Alternatively, if it is not a fix for net, then I suggest dropping
the Fixes tag and adding something about commit fbe346ce9d62 ("net: mana:
Handle Reset Request from MANA NIC") to the patch description, above the
tags (with a blank line in between).

> Signed-off-by: Long Li <longli@...rosoft.com>
> Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>
> ---
> Changes
> v2: Use a list for handling multiple devices.
>     Use disable_delayed_work_sync() on driver exit.
>     Replace atomic_t with flags to detect if interrupt happens before probe finishes
> 
> v3: Rebase to latest net-next. Change list_for_each_entry_safe() to while(!list_empty()).

Code changes look good to me.

Reviewed-by: Simon Horman <horms@...nel.org>