linux-kernel - Re: [PATCH] usb: typec: ucsi: fix probe failure in gaokun_ucsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2e8h4CBg=PsLmfcSCmfbVo+7mZZFM+GqcpVpZeU_B-gmyfUQ@mail.gmail.com>
Date: Tue, 25 Nov 2025 19:08:34 +0800
From: Pengyu Luo <mitltlatltl@...il.com>
To: Duoming Zhou <duoming@....edu.cn>
Cc: linux-usb@...r.kernel.org, gregkh@...uxfoundation.org, 
	heikki.krogerus@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: typec: ucsi: fix probe failure in gaokun_ucsi_probe()

On Tue, Nov 25, 2025 at 4:25 PM Duoming Zhou <duoming@....edu.cn> wrote:
>
> The gaokun_ucsi_probe() uses ucsi_create() to allocate a UCSI instance.
> The ucsi_create() validates whether ops->poll_cci is defined, and if not,
> it directly returns -EINVAL. However, the gaokun_ucsi_ops structure dose
> not define the poll_cci, causing ucsi_create() always fail with -EINVAL.
> This issue can be observed in the kernel log with the following error:
>
> ucsi_huawei_gaokun.ucsi huawei_gaokun_ec.ucsi.0: probe with driver
> ucsi_huawei_gaokun.ucsi failed with error -22
>
> Fix the issue by adding the missing poll_cci callback to gaokun_ucsi_ops.
>
> Fixes: 00327d7f2c8c ("usb: typec: ucsi: add Huawei Matebook E Go ucsi driver")
> Signed-off-by: Duoming Zhou <duoming@....edu.cn>

.poll_cci() was also introduced around that time. I missed it. Thanks
for fixing it up.

Reviewed-by: Pengyu Luo <mitltlatltl@...il.com>