linux-kernel - RE: [PATCH v3 3/5] riscv: dts: starfive: Add common board dtsi for VisionFive 2 Lite variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <ZQ2PR01MB13071D2B6401DF66E2EF1F95E6D12@ZQ2PR01MB1307.CHNPR01.prod.partner.outlook.cn>
Date: Tue, 25 Nov 2025 09:54:16 +0000
From: Hal Feng <hal.feng@...rfivetech.com>
To: Emil Renner Berthing <emil.renner.berthing@...onical.com>, Albert Ou
	<aou@...s.berkeley.edu>, Bjorn Helgaas <bhelgaas@...gle.com>, Conor Dooley
	<conor+dt@...nel.org>, E Shattow <e@...eshell.de>, Heinrich Schuchardt
	<heinrich.schuchardt@...onical.com>, Krzysztof Kozlowski
	<krzk+dt@...nel.org>, Krzysztof Wilczyński
	<kwilczynski@...nel.org>, Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Manivannan Sadhasivam <mani@...nel.org>, Palmer Dabbelt <palmer@...belt.com>,
	Paul Walmsley <pjw@...nel.org>, "Rafael J . Wysocki" <rafael@...nel.org>, Rob
 Herring <robh@...nel.org>, Viresh Kumar <viresh.kumar@...aro.org>
CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 3/5] riscv: dts: starfive: Add common board dtsi for
 VisionFive 2 Lite variants

> On 21.11.25 19:51, Emil Renner Berthing wrote: 
> Quoting Hal Feng (2025-11-20 09:29:44)
> > Add common board dtsi for use by VisionFive 2 Lite variants.
> >
> > Signed-off-by: Hal Feng <hal.feng@...rfivetech.com>
> > ---
> >  .../jh7110s-starfive-visionfive-2-lite.dtsi   | 691 ++++++++++++++++++
> >  1 file changed, 691 insertions(+)
> >  create mode 100644
> > arch/riscv/boot/dts/starfive/jh7110s-starfive-visionfive-2-lite.dtsi
> >
> > diff --git
> > a/arch/riscv/boot/dts/starfive/jh7110s-starfive-visionfive-2-lite.dtsi
> > b/arch/riscv/boot/dts/starfive/jh7110s-starfive-visionfive-2-lite.dtsi
> > new file mode 100644
> > index 000000000000..aa375c4a3fa3
> > --- /dev/null
> > +++ b/arch/riscv/boot/dts/starfive/jh7110s-starfive-visionfive-2-lite.
> > +++ dtsi
> > @@ -0,0 +1,691 @@
> > +// SPDX-License-Identifier: GPL-2.0 OR MIT
> > +/*
> > + * Copyright (C) 2025 StarFive Technology Co., Ltd.
> > + * Copyright (C) 2025 Hal Feng <hal.feng@...rfivetech.com>  */
> > +
> > +/dts-v1/;
> > +#include "jh7110.dtsi"
> > +#include "jh7110-pinfunc.h"
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/leds/common.h>
> > +#include <dt-bindings/pinctrl/starfive,jh7110-pinctrl.h>
> ''
> I'm confused. In [1] you said "remove jh7110s-common.dtsi, because only
> one board uses JH7110S now." but this series still adds two different boards.

In my view, VisionFive 2 Lite and VisionFive 2 Lite eMMC are one type of board,
but they have different storage components.

> 
> Also this derives from jh7110.dtsi rather than from jh7110-common.dts as I
> suggested in [2].

Sorry, I misunderstood your messages. I sent v4 [1] just now, please check it.
[1] https://lore.kernel.org/all/20251125075604.69370-1-hal.feng@starfivetech.com/

Best regards,
Hal

> 
> In any case I'm fine with doing it this way, so
> Acked-by: Emil Renner Berthing <emil.renner.berthing@...onical.com>
> 
> [1]: https://lore.kernel.org/linux-
> riscv/ZQ2PR01MB13076544E2136E7E7C2EEDA1E6CD2@...PR01MB1307.
> CHNPR01.prod.partner.outlook.cn/
> [2]: https://lore.kernel.org/linux-riscv/CAJM55Z-
> MfpVX3EuQ_AjvDSk6FwR51R5cQdN5RybS9pbJ8r9NNg@...l.gmail.com/